Skip to content

Commit

Permalink
build: add missing include in program_options.cc
Browse files Browse the repository at this point in the history
With GCC 14.2.1 and Boost 1.86.0 the code failed to compile due to
unknown type template `boost::type`. The include has been removed,
possibly accidentally, from the non-module build in aa1c8b3

[  1%] Building CXX object CMakeFiles/seastar.dir/src/core/program_options.cc.o
/home/krzaq/code/temp/seastar/src/core/program_options.cc:82:64: error: ‘boost::type’ has not been declared
   82 | memory::alloc_failure_kind from_string(const std::string& val, boost::type<memory::alloc_failure_kind>) {
      |                                                                ^~~~~
/home/krzaq/code/temp/seastar/src/core/program_options.cc:82:75: error: expected ‘,’ or ‘...’ before ‘<’ token
   82 | memory::alloc_failure_kind from_string(const std::string& val, boost::type<memory::alloc_failure_kind>) {
      |                                                                           ^
/home/krzaq/code/temp/seastar/src/core/program_options.cc:93:47: error: ‘boost::type’ has not been declared
   93 | log_level from_string(const std::string& val, boost::type<log_level>) {
      |                                               ^~~~~
/home/krzaq/code/temp/seastar/src/core/program_options.cc:93:58: error: expected ‘,’ or ‘...’ before ‘<’ token
   93 | log_level from_string(const std::string& val, boost::type<log_level>) {
      |                                                          ^
/home/krzaq/code/temp/seastar/src/core/program_options.cc:93:11: error: ambiguating new declaration of ‘seastar::log_level seastar::program_options::{anonymous}::from_string(const std::string&, int)’
   93 | log_level from_string(const std::string& val, boost::type<log_level>) {
      |           ^~~~~~~~~~~
  • Loading branch information
KrzaQ committed Jan 21, 2025
1 parent 808766d commit 8ac2a79
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/core/program_options.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ module;
#include <fmt/format.h>
module seastar;
#else
#include <boost/type.hpp>

#include "core/program_options.hh"

#include <seastar/util/log-cli.hh>
Expand Down

0 comments on commit 8ac2a79

Please sign in to comment.