Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci and other stuff #1220

Closed

Conversation

Lorak-mmk
Copy link
Collaborator

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

dkropachev and others added 30 commits February 10, 2025 16:11
Cleanup unused dependancies
Implement simple abstraction that allows to run commands logging
command, return status, stderr and stdout to a file and optionally to
stderr/stdout
In order to programatically manipulate by scylla.yaml and cassandra.yaml
We need to have some struct that provides API for that.
It also needs to represent it in the way that ccm updateconf understand
CCM is cli tool to ease scylla/cassandra/dse cluster management.
Using it in integration suit will help to expand test coverage.
Will be removed later. Added it so the file compiles.
This is an initial version (without any spans etc.).
It's not going to be used, since we log ccm commands using tracing.
Async closures are not yet supported.
It was release over 6 months ago so it is ok.
It allows us to use LazyCell.
Tests were not passing because tests tried to use the same dir
concurrently.
For now it will run on each PR.
Later we may do it differently.
@Lorak-mmk Lorak-mmk changed the base branch from main to branch-hackathon February 10, 2025 19:47
Copy link

github-actions bot commented Feb 10, 2025

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 5bea1a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants