-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci and other stuff #1220
Closed
Lorak-mmk
wants to merge
32
commits into
scylladb:branch-hackathon
from
Lorak-mmk:ci-and-other-stuff
Closed
Ci and other stuff #1220
Lorak-mmk
wants to merge
32
commits into
scylladb:branch-hackathon
from
Lorak-mmk:ci-and-other-stuff
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup unused dependancies
Implement simple abstraction that allows to run commands logging command, return status, stderr and stdout to a file and optionally to stderr/stdout
In order to programatically manipulate by scylla.yaml and cassandra.yaml We need to have some struct that provides API for that. It also needs to represent it in the way that ccm updateconf understand
CCM is cli tool to ease scylla/cassandra/dse cluster management. Using it in integration suit will help to expand test coverage.
Will be removed later. Added it so the file compiles.
This is an initial version (without any spans etc.).
It's not going to be used, since we log ccm commands using tracing.
Async closures are not yet supported.
It was release over 6 months ago so it is ok. It allows us to use LazyCell.
Tests were not passing because tests tried to use the same dir concurrently.
For now it will run on each PR. Later we may do it differently.
|
e984fb8
to
22e5dfc
Compare
22e5dfc
to
5bea1a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.