Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement (derive) Debug for MaybeUnset #1199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stanislav-tkach
Copy link

@stanislav-tkach stanislav-tkach commented Feb 4, 2025

In our project we have multiple structures that derive SerializeRow and we often want to print them, but as MaybeUnset doesn't implement Debug we are forced to manually implement it.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Copy link

github-actions bot commented Feb 4, 2025

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: a490744

Copy link
Contributor

@muzarski muzarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably merge it after #1198 so @Lorak-mmk doesn't have to resolve the conflicts while working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants