-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: rename QueryError
to ExecutionError
#1185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzarski
force-pushed
the
rename-query-error
branch
from
January 30, 2025 14:20
f9a3b49
to
d740d85
Compare
muzarski
requested review from
Lorak-mmk and
wprzytula
and removed request for
Lorak-mmk
January 30, 2025 14:24
github-actions
bot
added
the
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
label
Jan 30, 2025
See the following report for details: cargo semver-checks output
|
wprzytula
previously approved these changes
Jan 30, 2025
wprzytula
approved these changes
Jan 30, 2025
Lorak-mmk
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API-stability
Part of the effort to stabilize the API
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #519
Step forward: #713
As the PR titles says, this PR renames the
QueryError
toExecutionError
. I also checked the mentions of the QueryError in the docs - last commit adjusts the docs regarding the error returned in case of schema agreement timeout.Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce../docs/source/
.Fixes:
annotations to PR description.