Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce function to deserialize CloudConfig from Read #1183

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Introduce function to deserialize CloudConfig from Read #1183

wants to merge 5 commits into from

Conversation

RomanHargrave
Copy link

@RomanHargrave RomanHargrave commented Jan 29, 2025 •
edited
Loading

In many cases, it may be desirable to store the contents of the cloud configuration YAML outside of the local filesystem. In order to support this, all that should be necessary is to allow for CloudConfig to be deserialized from a Read, rather than a file located at some path, and to allow for the CloudSessionBuilder to be constructed from an existing CloudConfig.

I considered a CloudSessionBuilder constructor which accepted a Read, but settled on accepting CloudConfig instead as this seemed more logical by a small margin. I would ultimately be comfortable with either implementation, depending on maintainer preference.

Draft because I need to address some of the checklist items.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@RomanHargrave RomanHargrave changed the title Support for cloud configuration stored in places other than the local filesystem Public interface to deserialize CloudConfiguration from Read Jan 29, 2025
@RomanHargrave RomanHargrave changed the title Public interface to deserialize CloudConfiguration from Read Introduce function to deserialize CloudConfiguration from Read Jan 29, 2025
@RomanHargrave RomanHargrave changed the title Introduce function to deserialize CloudConfiguration from Read Introduce function to deserialize CloudConfig from Read Jan 29, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

cargo semver-checks detected some API incompatibilities in this PR.
Checked commit: c18764f

See the following report for details:

cargo semver-checks output 
./scripts/semver-checks.sh --baseline-rev b6a3e01d8aec2842352d193b54f09ccaedfcbcbf
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev b6a3e01d8aec2842352d193b54f09ccaedfcbcbf
     Cloning b6a3e01d8aec2842352d193b54f09ccaedfcbcbf
    Building scylla v0.15.0 (current)
       Built [  24.864s] (current)
     Parsing scylla v0.15.0 (current)
      Parsed [   0.050s] (current)
    Building scylla v0.15.0 (baseline)
       Built [  22.809s] (baseline)
     Parsing scylla v0.15.0 (baseline)
      Parsed [   0.050s] (baseline)
    Checking scylla v0.15.0 -> v0.15.0 (no change)
     Checked [   0.120s] 127 checks: 119 pass, 8 fail, 0 warn, 0 skip

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field Column.typ in /home/runner/work/scylla-rust-driver/scylla-rust-driver/scylla/src/cluster/metadata.rs:209

--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_missing.ron

Failed in:
  enum scylla::client::pager::LegacyNextRowError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/client/pager.rs:1177
  enum scylla::errors::ViewsMetadataError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:546
  enum scylla::cluster::metadata::CqlType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/cluster/metadata.rs:269
  enum scylla::errors::UseKeyspaceProtocolError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:356
  enum scylla::client::session::CurrentDeserializationApi, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/client/session.rs:83
  enum scylla::cluster::metadata::CollectionType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/cluster/metadata.rs:392
  enum scylla::errors::QueryError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:46
  enum scylla::response::legacy_query_result::MaybeFirstRowTypedError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:286
  enum scylla::client::session::LegacyDeserializationApi, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/client/session.rs:91
  enum scylla::response::legacy_query_result::IntoLegacyQueryResultError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:203
  enum scylla::response::legacy_query_result::FirstRowTypedError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:263
  enum scylla::response::legacy_query_result::SingleRowTypedError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:324
  enum scylla::cluster::metadata::NativeType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/cluster/metadata.rs:306
  enum scylla::response::legacy_query_result::FirstRowError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:249
  enum scylla::response::legacy_query_result::SingleRowError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:305

--- failure enum_variant_missing: pub enum variant removed or renamed ---

Description:
A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_variant_missing.ron

Failed in:
  variant ProtocolError::PreparedStatementIdsMismatch, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:306
  variant ProtocolError::UseKeyspace, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:321
  variant ProtocolError::InvalidCqlType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:333
  variant TablesMetadataError::SchemaTablesInvalidColumnType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:527
  variant TablesMetadataError::SchemaColumnsInvalidColumnType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:531
  variant BadQuery::SerializeValuesError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:564
  variant BadQuery::BadKeyspaceName, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:575
  variant BadQuery::Other, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:583
  variant NewSessionError::DbError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:202
  variant NewSessionError::BadQuery, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:206
  variant NewSessionError::CqlRequestSerialization, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:210
  variant NewSessionError::EmptyPlan, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:219
  variant NewSessionError::BodyExtensionsParseError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:223
  variant NewSessionError::CqlResultParseError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:231
  variant NewSessionError::CqlErrorParseError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:235
  variant NewSessionError::ConnectionPoolError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:239
  variant NewSessionError::ProtocolError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:243
  variant NewSessionError::TimeoutError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:247
  variant NewSessionError::BrokenConnection, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:251
  variant NewSessionError::UnableToAllocStreamId, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:255
  variant NewSessionError::RequestTimeout, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:262
  variant NewSessionError::SchemaAgreementTimeout, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:266
  variant NewSessionError::NextRowError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:274
  variant NewSessionError::IntoLegacyQueryResultError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:284
  variant UdtMetadataError::SchemaTypesInvalidColumnType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:514
  variant KeyspacesMetadataError::SchemaKeyspacesInvalidColumnType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:476
  variant PeersMetadataError::SystemPeersInvalidColumnType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:455
  variant PeersMetadataError::SystemLocalInvalidColumnType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:459
  variant MetadataError::Views, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:446

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/inherent_method_missing.ron

Failed in:
  Node::is_down, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/cluster/node.rs:165
  GenericSessionBuilder::build_legacy, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/client/session_builder.rs:568
  QueryPager::into_legacy, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/client/pager.rs:681
  RequestAttemptError::into_query_error, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:998
  PartitionKeyError::into_query_error, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/statement/prepared_statement.rs:498
  PartitionKeyError::into_query_error, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/statement/prepared_statement.rs:498
  RequestError::into_query_error, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/errors.rs:918
  QueryResult::into_legacy_result, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/query_result.rs:267

--- failure module_missing: pub module removed or renamed ---

Description:
A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/module_missing.ron

Failed in:
  mod scylla::response::legacy_query_result, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:1

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_missing.ron

Failed in:
  struct scylla::client::session::GenericSession, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/client/session.rs:98
  struct scylla::client::pager::LegacyTypedRowIterator, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/client/pager.rs:1152
  struct scylla::client::caching_session::GenericCachingSession, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/client/caching_session.rs:43
  struct scylla::cluster::metadata::UserDefinedType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/cluster/metadata.rs:291
  struct scylla::response::legacy_query_result::RowsNotExpectedError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:246
  struct scylla::cluster::metadata::NativeTypeFromStrError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/cluster/metadata.rs:331
  struct scylla::response::legacy_query_result::RowsExpectedError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:233
  struct scylla::client::session::TypedRowIter, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:40
  struct scylla::response::legacy_query_result::TypedRowIter, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:40
  struct scylla::response::legacy_query_result::LegacyQueryResult, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:61
  struct scylla::client::pager::LegacyRowIterator, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/client/pager.rs:1099

--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---

Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_pub_field_missing.ron

Failed in:
  field type_ of struct Column, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/cluster/metadata.rs:203

--- failure trait_missing: pub trait removed or renamed ---

Description:
A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_missing.ron

Failed in:
  trait scylla::client::session::IntoTypedRows, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:19
  trait scylla::response::legacy_query_result::IntoTypedRows, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/response/legacy_query_result.rs:19
  trait scylla::client::session::DeserializationApiKind, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla/src/client/session.rs:81

     Summary semver requires new major version: 8 major and 0 minor checks failed
    Finished [  48.790s] scylla
    Building scylla-cql v0.4.0 (current)
       Built [  10.938s] (current)
     Parsing scylla-cql v0.4.0 (current)
      Parsed [   0.027s] (current)
    Building scylla-cql v0.4.0 (baseline)
       Built [  10.993s] (baseline)
     Parsing scylla-cql v0.4.0 (baseline)
      Parsed [   0.034s] (baseline)
    Checking scylla-cql v0.4.0 -> v0.4.0 (no change)
     Checked [   0.120s] 127 checks: 116 pass, 11 fail, 0 warn, 0 skip

--- failure declarative_macro_missing: macro_rules declaration removed or renamed ---

Description:
A `macro_rules!` declarative macro cannot be invoked by its prior name. The macro may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/reference/macros-by-example.html#path-based-scope
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/declarative_macro_missing.ron

Failed in:
  macro impl_serialize_row_via_value_list, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/row.rs:425
  macro impl_serialize_row_via_value_list, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/row.rs:425
  macro impl_serialize_row_via_value_list, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/row.rs:425
  macro impl_from_cql_value_from_method, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:116
  macro impl_from_cql_value_from_method, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:116
  macro impl_from_cql_value_from_method, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:116
  macro impl_serialize_value_via_value, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/value.rs:955
  macro impl_serialize_value_via_value, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/value.rs:955
  macro impl_serialize_value_via_value, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/value.rs:955

--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_missing.ron

Failed in:
  enum scylla_cql::frame::response::cql_to_rust::FromCqlValError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:42
  enum scylla_cql::cql_to_rust::FromCqlValError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:42
  enum scylla_cql::_macro_internal::FromCqlValError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:42
  enum scylla_cql::serialize::row::ValueListToSerializeRowAdapterError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/row.rs:724
  enum scylla_cql::serialize::value::ValueToSerializeValueAdapterError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/value.rs:1509
  enum scylla_cql::frame::value::SerializeValuesError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:814
  enum scylla_cql::frame::response::cql_to_rust::FromRowError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:19
  enum scylla_cql::cql_to_rust::FromRowError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:19
  enum scylla_cql::_macro_internal::FromRowError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:19

--- failure enum_struct_variant_field_added: pub enum struct variant field added ---

Description:
An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant.
        ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_struct_variant_field_added.ron

Failed in:
  field frozen of variant ColumnType::UserDefinedType in /home/runner/work/scylla-rust-driver/scylla-rust-driver/scylla-cql/src/frame/response/result.rs:81
  field definition of variant ColumnType::UserDefinedType in /home/runner/work/scylla-rust-driver/scylla-rust-driver/scylla-cql/src/frame/response/result.rs:82
  field name of variant CqlValue::UserDefinedType in /home/runner/work/scylla-rust-driver/scylla-rust-driver/scylla-cql/src/frame/response/result.rs:215

--- failure enum_struct_variant_field_missing: pub enum struct variant's field removed or renamed ---

Description:
A publicly-visible enum has a struct variant whose field is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_struct_variant_field_missing.ron

Failed in:
  field type_name of variant ColumnType::UserDefinedType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:73
  field keyspace of variant ColumnType::UserDefinedType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:74
  field field_types of variant ColumnType::UserDefinedType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:75
  field type_name of variant CqlValue::UserDefinedType, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:160

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_variant_added.ron

Failed in:
  variant ColumnType:Native in /home/runner/work/scylla-rust-driver/scylla-rust-driver/scylla-cql/src/frame/response/result.rs:62
  variant ColumnType:Collection in /home/runner/work/scylla-rust-driver/scylla-rust-driver/scylla-cql/src/frame/response/result.rs:66
  variant ColumnType:Vector in /home/runner/work/scylla-rust-driver/scylla-rust-driver/scylla-cql/src/frame/response/result.rs:74

--- failure enum_variant_missing: pub enum variant removed or renamed ---

Description:
A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_variant_missing.ron

Failed in:
  variant BuiltinDeserializationErrorKind::CustomTypeNotSupported, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/deserialize/value.rs:1782
  variant BuiltinTypeCheckErrorKind::CustomTypeUnsupported, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/value.rs:1152
  variant ColumnType::Custom, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:54
  variant ColumnType::Ascii, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:55
  variant ColumnType::Boolean, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:56
  variant ColumnType::Blob, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:57
  variant ColumnType::Counter, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:58
  variant ColumnType::Date, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:59
  variant ColumnType::Decimal, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:60
  variant ColumnType::Double, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:61
  variant ColumnType::Duration, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:62
  variant ColumnType::Float, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:63
  variant ColumnType::Int, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:64
  variant ColumnType::BigInt, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:65
  variant ColumnType::Text, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:66
  variant ColumnType::Timestamp, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:67
  variant ColumnType::Inet, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:68
  variant ColumnType::List, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:69
  variant ColumnType::Map, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:70
  variant ColumnType::Set, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:71
  variant ColumnType::SmallInt, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:77
  variant ColumnType::TinyInt, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:78
  variant ColumnType::Time, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:79
  variant ColumnType::Timeuuid, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:80
  variant ColumnType::Uuid, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:82
  variant ColumnType::Varint, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:83

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/function_missing.ron

Failed in:
  function scylla_cql::serialize::value::serialize_legacy_value, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/value.rs:1019
  function scylla_cql::serialize::row::serialize_legacy_row, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/row.rs:507

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/inherent_method_missing.ron

Failed in:
  Row::into_typed, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/result.rs:616

--- failure module_missing: pub module removed or renamed ---

Description:
A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/module_missing.ron

Failed in:
  mod scylla_cql::frame::response::cql_to_rust, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:1
  mod scylla_cql::cql_to_rust, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:1

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_missing.ron

Failed in:
  struct scylla_cql::frame::value::LegacyBatchValuesIteratorFromIterator, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:1034
  struct scylla_cql::serialize::row::ValueListAdapter, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/row.rs:459
  struct scylla_cql::serialize::value::ValueAdapter, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/value.rs:984
  struct scylla_cql::serialize::batch::LegacyBatchValuesAdapter, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/batch.rs:340
  struct scylla_cql::serialize::batch::LegacyBatchValuesIteratorAdapter, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/serialize/batch.rs:364
  struct scylla_cql::frame::value::ValueTooBig, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:811
  struct scylla_cql::_macro_internal::ValueTooBig, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:811
  struct scylla_cql::frame::value::LegacySerializedValues, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:828
  struct scylla_cql::_macro_internal::LegacySerializedValues, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:828
  struct scylla_cql::frame::value::LegacyBatchValuesFirstSerialized, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:1960
  struct scylla_cql::frame::value::LegacySerializedValuesIterator, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:968
  struct scylla_cql::frame::value::TupleValuesIter, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:1862
  struct scylla_cql::frame::value::LegacyBatchValuesFromIter, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:1786

--- failure trait_missing: pub trait removed or renamed ---

Description:
A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_missing.ron

Failed in:
  trait scylla_cql::frame::response::cql_to_rust::FromCqlVal, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:33
  trait scylla_cql::cql_to_rust::FromCqlVal, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:33
  trait scylla_cql::_macro_internal::FromCqlVal, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:33
  trait scylla_cql::frame::value::LegacyBatchValues, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:992
  trait scylla_cql::frame::response::cql_to_rust::FromRow, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:56
  trait scylla_cql::cql_to_rust::FromRow, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:56
  trait scylla_cql::_macro_internal::FromRow, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:56
  trait scylla_cql::FromRow, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/response/cql_to_rust.rs:56
  trait scylla_cql::frame::value::ValueList, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:838
  trait scylla_cql::_macro_internal::ValueList, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:838
  trait scylla_cql::frame::value::LegacyBatchValuesIterator, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:1011
  trait scylla_cql::frame::value::Value, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:805
  trait scylla_cql::_macro_internal::Value, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-b6a3e01d8aec2842352d193b54f09ccaedfcbcbf/0693068e3bfa5b13fdac54af42ffeba4d62b4be0/scylla-cql/src/frame/value.rs:805

     Summary semver requires new major version: 11 major and 0 minor checks failed
    Finished [  22.616s] scylla-cql
make: *** [Makefile:61: semver-rev] Error 1

@RomanHargrave RomanHargrave marked this pull request as ready for review February 3, 2025 19:12
@github-actions github-actions bot added the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Feb 3, 2025
@wprzytula wprzytula requested review from wprzytula and muzarski and removed request for wprzytula February 4, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muzarski muzarski Awaiting requested review from muzarski

@wprzytula wprzytula Awaiting requested review from wprzytula

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RomanHargrave