Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: metadata errors refactor #1170

Merged
merged 15 commits into from
Jan 29, 2025
+211 −164
Merged

errors: metadata errors refactor #1170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
30a0015
errors: introduce MetadataFetchError
muzarski Jan 28, 2025
71dc4c3
metadata: narrow error type of query_table_partitioners
muzarski Dec 30, 2024
45e9bcc
metadata: convert errors in query_filter_keyspace_name
muzarski Dec 30, 2024
1b7b8f2
errors: move InvalidCqlType from ProtocolError to metadata errors
muzarski Dec 30, 2024
a843b54
metadata: narrow error type of query_tables_schema
muzarski Dec 30, 2024
ffdfd7e
metadata: narrow error type of query_views
muzarski Dec 30, 2024
0ef2d2a
metadata: narrow error type of query_tables
muzarski Dec 30, 2024
e7f5c1d
metadata: narrow error type of query_user_defined_types
muzarski Dec 30, 2024
9337cc5
metadata: remove Result from return type of create_peer_from_row
muzarski Dec 30, 2024
14af9e6
metadata: narrow error type of query_keyspaces
muzarski Dec 30, 2024
381bf3b
metadata: narrow error type of query_peers
muzarski Dec 30, 2024
c66a1f9
metadata: narrow error type of query_metadata
muzarski Dec 30, 2024
5ea4d7a
metadata: replace remaining QueryError occurrences in the module
muzarski Dec 30, 2024
9916c49
cluster/session: replace QueryError with MetadataError in refresh path
muzarski Dec 30, 2024
1d10e56
errors: remove unused variants and metadata error types
muzarski Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scylla/src/client/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ use crate::cluster::node::CloudEndpoint;
use crate::cluster::node::{InternalKnownNode, KnownNode, NodeRef};
use crate::cluster::{Cluster, ClusterNeatDebug, ClusterState};
use crate::errors::{
BadQuery, NewSessionError, ProtocolError, QueryError, RequestAttemptError, RequestError,
TracingProtocolError,
BadQuery, MetadataError, NewSessionError, ProtocolError, QueryError, RequestAttemptError,
RequestError, TracingProtocolError,
};
use crate::frame::response::result;
#[cfg(feature = "ssl")]
Expand Down Expand Up @@ -1717,7 +1717,7 @@ where
///
/// Normally this is not needed,
/// the driver should automatically detect all metadata changes in the cluster
pub async fn refresh_metadata(&self) -> Result<(), QueryError> {
pub async fn refresh_metadata(&self) -> Result<(), MetadataError> {
self.cluster.refresh_metadata().await
}

Expand Down
Loading