Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add explicit step to update apt cache in jobs #190

Merged
merged 2 commits into from
Nov 18, 2024
Merged

ci: add explicit step to update apt cache in jobs #190

merged 2 commits into from
Nov 18, 2024

Conversation

muzarski
Copy link
Collaborator

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have implemented Rust unit tests for the features/changes introduced.
  • I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

@muzarski muzarski marked this pull request as draft October 14, 2024 14:06
@muzarski muzarski force-pushed the fix-ci branch 5 times, most recently from 923c492 to 6337b45 Compare October 14, 2024 17:40
@muzarski muzarski self-assigned this Oct 15, 2024
@muzarski muzarski force-pushed the fix-ci branch 10 times, most recently from 929c545 to 4688ee1 Compare October 15, 2024 10:27
@muzarski muzarski force-pushed the fix-ci branch 4 times, most recently from 8f09a98 to 10253ad Compare November 12, 2024 17:39
@muzarski
ci: add comment on how apt cache refreshing works there
60693ec
@muzarski
ci: update apt cache in each job
5e72765 
It looks like `update-apt-cache-if-needed` from Makefile does not always
recognizes that apt cache needs to be updated during CI. We adjust an explicit
step of updating apt cache to each job.

I decided to retain the `update-apt-cache-if-needed` in Makefile, since it may
be useful for local development.
@muzarski muzarski requested a review from dkropachev November 18, 2024 12:44
@muzarski muzarski marked this pull request as ready for review November 18, 2024 12:44
@muzarski muzarski changed the title fix CI ci: add explicit step to update apt cache in jobs Nov 18, 2024
@muzarski
Copy link
Collaborator Author

@dkropachev I adjusted this PR, according to what we discussed during our call

@dkropachev dkropachev merged commit fa9d905 into scylladb:master Nov 18, 2024
11 checks passed
@muzarski muzarski mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkropachev dkropachev Awaiting requested review from dkropachev

Assignees

@muzarski muzarski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzarski @dkropachev