resolves spatialdata_io.xenium() capability to read in xeniumranger v3.0.1.1 resegemented data #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranching in xenium()
…ion detection after resegment needed within xenium.py for correct xenium() parsing/branching of /outs/ folder path input generated from the xeniumranger v3.0.1.1 resegment
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
- Coverage 45.31% 39.16% -6.15%
==========================================
Files 22 26 +4
Lines 2143 2663 +520
==========================================
+ Hits 971 1043 +72
- Misses 1172 1620 +448
|
|
Thank you @Pancreas-Pratik for making a PR! I will try this soon and give my comments. |
for more information, see https://pre-commit.ci
|
Thank you @Pancreas-Pratik for the contribution! Today I tried out the code and I confirm that it works as expected. I'll merge your PR (I'll fix the problem with the docs before release). |
LucaMarconato
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #195 (comment)
versionfrom new specXENIUM_RANGER = "xenium_ranger", which allows the re-segmented/outs/data to pass through the existingspatialdata_io.xenium()successfully(this is my first pull request... in any repository... please correct me if I am doing something wrong)