Code

feat: add secp256r1 support#1351

Code

Merged

lispc merged 72 commits intodevelopscroll-tech/zkevm-circuits:developfrom feat/secp256r1scroll-tech/zkevm-circuits:feat/secp256r1Copy head branch name to clipboardOct 30, 2024

+1,182-216

Commits

Commits on Jun 27, 2024

• update SignData with generic type

  DreamWuGit

  committed
  2d238e3

  Copy full SHA for 2d238e3

• update PrecompileEvent::SignData

  DreamWuGit

  committed
  f430f3d

  Copy full SHA for f430f3d

• update some SignDatas

  DreamWuGit

  committed
  29f7c34

  Copy full SHA for 29f7c34

• add sig circuit signatures_r1

  DreamWuGit

  committed
  1b7d0f2

  Copy full SHA for 1b7d0f2

• change tx circuit regarding signdata

  DreamWuGit

  committed
  9c59cf3

  Copy full SHA for 9c59cf3

Commits on Jun 28, 2024

• sig table adds p256 signatures

  DreamWuGit

  committed
  ca79ecc

  Copy full SHA for ca79ecc

• add ecdsa_r1_config

  DreamWuGit

  committed
  fb1d74a

  Copy full SHA for fb1d74a

Commits on Jul 1, 2024

• add FpChipR1 type

  DreamWuGit

  committed
  435c392

  Copy full SHA for 435c392

• fix comment

  DreamWuGit

  committed
  bdff1f7

  Copy full SHA for bdff1f7

• Merge branch 'develop' into feat/secp256r1

  DreamWuGit

  authored
  aad86aa

  Copy full SHA for aad86aa

Commits on Jul 2, 2024

• rename FpChip

  DreamWuGit

  committed
  ffd9263

  Copy full SHA for ffd9263

Commits on Jul 3, 2024

• add assign_ecdsa_generic method

  DreamWuGit

  committed
  7272aa1

  Copy full SHA for 7272aa1

• fix assign_ecdsa_generic issue

  DreamWuGit

  committed
  01e6f94

  Copy full SHA for 01e6f94

Commits on Jul 4, 2024

• update sign_data_decomposition_generic

  DreamWuGit

  committed
  71d64fe

  Copy full SHA for 71d64fe

• make pk_bytes_le_generic helper

  DreamWuGit

  committed
  be10b33

  Copy full SHA for be10b33

Commits on Jul 5, 2024

• apply sign_data_decomposition_generic

  DreamWuGit

  committed
  0d72669

  Copy full SHA for 0d72669

• add assign_sig_verify_generic

  DreamWuGit

  committed
  266fc75

  Copy full SHA for 266fc75

Commits on Jul 7, 2024

• apply assign_sig_verify_generic

  DreamWuGit

  committed
  9c35569

  Copy full SHA for 9c35569

Commits on Jul 9, 2024

• ecdsa_r1_config.range load lookup

  DreamWuGit

  committed
  65a80f3

  Copy full SHA for 65a80f3

Commits on Jul 10, 2024

• update existing sig circuit tests

  DreamWuGit

  committed
  1ebd7bf

  Copy full SHA for 1ebd7bf

• add helper sign_generic

  DreamWuGit

  committed
  cf4ccef

  Copy full SHA for cf4ccef

• rename sign_generic to sign and remove old method

  DreamWuGit

  committed
  b469244

  Copy full SHA for b469244

Commits on Jul 11, 2024

• add new test p256_sign_verify

  DreamWuGit

  committed
  e6d5784

  Copy full SHA for e6d5784

• add random msg_hash test

  DreamWuGit

  committed
  15476f3

  Copy full SHA for 15476f3

• add sign_verify and rename old

  DreamWuGit

  committed
  116a56b

  Copy full SHA for 116a56b

• sign_verify fill with k1 & r1 test data

  DreamWuGit

  committed
  fea64c4

  Copy full SHA for fea64c4

Commits on Jul 12, 2024

• msg_hash == 0 case

  DreamWuGit

  committed
  29ea9b2

  Copy full SHA for 29ea9b2

Commits on Oct 9, 2024

• sync develop branch

  DreamWuGit

  committed
  748ec0b

  Copy full SHA for 748ec0b

• fix merge error

  DreamWuGit

  committed
  54207ec

  Copy full SHA for 54207ec

Commits on Oct 10, 2024

• update cargo for halo2-lib version

  DreamWuGit

  committed
  4650850

  Copy full SHA for 4650850

• replace FqChipK1

  DreamWuGit

  committed
  d26cdb8

  Copy full SHA for d26cdb8

Commits on Oct 11, 2024

• two chips use one RangeConfig & remove

  DreamWuGit

  committed
  faf30bd

  Copy full SHA for faf30bd

• keccak lookup for r1 pk hash

  DreamWuGit

  committed
  b9c76ec

  Copy full SHA for b9c76ec

• fix keccak input bytes

  DreamWuGit

  committed
  0204f98

  Copy full SHA for 0204f98

Commits on Oct 12, 2024

• misc update

  DreamWuGit

  committed
  24916f3

  Copy full SHA for 24916f3

Commits on Oct 14, 2024

• add temp debug info

  DreamWuGit

  committed
  5ac53a2

  Copy full SHA for 5ac53a2

Commits on Oct 15, 2024

• revert temp two RangeChip

  DreamWuGit

  committed
  92f8040

  Copy full SHA for 92f8040

Commits on Oct 17, 2024

• p256 not check v & y oddness match

  DreamWuGit

  committed
  14d0184

  Copy full SHA for 14d0184

• add helper is_p256_precompile

  DreamWuGit

  committed
  76df7bf

  Copy full SHA for 76df7bf

• add p256 crate test

  DreamWuGit

  committed
  9e63de1

  Copy full SHA for 9e63de1

Commits on Oct 19, 2024

• add verify sig helper

  DreamWuGit

  committed
  0fd1512

  Copy full SHA for 0fd1512

Commits on Oct 24, 2024

• tests against p256 branch

  DreamWuGit

  committed
  9092084

  Copy full SHA for 9092084

• comment out p256 crate test

  DreamWuGit

  committed
  cb98f49

  Copy full SHA for cb98f49

Commits on Oct 25, 2024

• update halo2-lib branch & ecc_circuit::decompose_ec_mul_op

  DreamWuGit

  committed
  8300bf7

  Copy full SHA for 8300bf7

• remove debug info

  DreamWuGit

  committed
  2c77320

  Copy full SHA for 2c77320

• max_verify into max_verify_k1&max_verify_r1

  DreamWuGit

  committed
  262dc23

  Copy full SHA for 262dc23

Commits on Oct 26, 2024

• update test per max_verify

  DreamWuGit

  committed
  45c4487

  Copy full SHA for 45c4487

Commits on Oct 27, 2024

• pad default sigdata

  DreamWuGit

  committed
  40f5d6c

  Copy full SHA for 40f5d6c

Commits on Oct 28, 2024

• fix pad sig lookup

  DreamWuGit

  committed
  b12de56

  Copy full SHA for b12de56

• pad default

  DreamWuGit

  committed
  96c48a5

  Copy full SHA for 96c48a5

• Merge branch 'develop' into feat/secp256r1

  DreamWuGit

  authored
  b3e0d6e

  Copy full SHA for b3e0d6e

• update types

  DreamWuGit

  committed
  212e1b0

  Copy full SHA for 212e1b0

• Merge branch 'feat/secp256r1' of https://github.com/scroll-tech/zkevm-circuits into feat/secp256r1

  DreamWuGit

  committed
  01bd0d1

  Copy full SHA for 01bd0d1

• clippy & comment

  DreamWuGit

  committed
  ab99141

  Copy full SHA for ab99141

• modify test

  DreamWuGit

  committed
  cd7d774

  Copy full SHA for cd7d774

• remove unused codes of sig circuit

  DreamWuGit

  committed
  402b1c6

  Copy full SHA for 402b1c6

• adjust MAX_NUM_SIG_K1&R1

  DreamWuGit

  committed
  78d85e8

  Copy full SHA for 78d85e8

Commits on Oct 29, 2024

• Update utils.rs

  lispc

  authored
  a045cda

  Copy full SHA for a045cda

• Update sig_circuit.rs

  lispc

  authored
  859ef81

  Copy full SHA for 859ef81

• Update utils.rs

  lispc

  authored
  980b8d9

  Copy full SHA for 980b8d9

• Update utils.rs

  lispc

  authored
  a9c5b20

  Copy full SHA for a9c5b20

• Update utils.rs

  lispc

  authored
  4853bcb

  Copy full SHA for 4853bcb

• const limbits, num_limbs

  DreamWuGit

  committed
  8116b60

  Copy full SHA for 8116b60

• increase COLUMN_NUM_LIMIT

  DreamWuGit

  committed
  267d759

  Copy full SHA for 267d759

• use accurate CELLS_PER_SIG, adjust min_num

  DreamWuGit

  committed
  355e337

  Copy full SHA for 355e337

• handle padding in get_sign_data_p256

  DreamWuGit

  committed
  a864510

  Copy full SHA for a864510

• try keccak

  DreamWuGit

  committed
  991bee2

  Copy full SHA for 991bee2

Commits on Oct 30, 2024

• disable assigned_keccak_values_r1 & clean

  DreamWuGit

  committed
  1566e61

  Copy full SHA for 1566e61

• enable assigned_keccak_values_r1

  DreamWuGit

  committed
  e920030

  Copy full SHA for e920030

• clippy

  DreamWuGit

  committed
  6158319

  Copy full SHA for 6158319

• clippy

  DreamWuGit

  committed
  dc4bfd9

  Copy full SHA for dc4bfd9

• fix fmt

  DreamWuGit

  committed
  308ede9

  Copy full SHA for 308ede9