Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick #1719 from upstream: fix begin-tx tx_id soundness #1078

Merged
merged 5 commits into from
Feb 2, 2024

Conversation

lispc
Copy link

@lispc lispc commented Jan 8, 2024

This PR fixes 3 soundness issues related to begin-tx / end-tx / end-block / end-inner-block

  1. The tx_id constrain between end-tx and next begin-tx. (Mentioned upstream soundness: begin_tx tx_id should be read? privacy-scaling-explorations/zkevm-circuits#1707)
  2. The constrain of StepStateTransition between end-tx and next end-inner-block. (Mentioned on asana)
  3. The constrain of StepStateTransition betwwen end-inner-block and end-block. (I noticed this during fixing above 2)

@kunxian-xia kunxian-xia self-requested a review January 31, 2024 03:30
Copy link

@kunxian-xia kunxian-xia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one small question.

@lispc lispc merged commit e90ea7e into develop Feb 2, 2024
15 checks passed
@lispc lispc deleted the fix/begin-tx-soundness branch February 2, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants