Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coordinator): assign chunk task bug #1515

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

georgehao
Copy link
Member

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@georgehao georgehao requested a review from colinlyguo August 30, 2024 17:21
@georgehao georgehao added the bump-version Bump the version tag for deployment label Aug 30, 2024
@colinlyguo colinlyguo changed the title Feat/fix coordinator assign chunk bug fix: coordinator assign chunk bug Aug 30, 2024
@colinlyguo colinlyguo changed the title fix: coordinator assign chunk bug fix(coordinator): assign chunk task bug Aug 30, 2024
colinlyguo
colinlyguo previously approved these changes Aug 30, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.61%. Comparing base (2ee1c89) to head (92e29c0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
coordinator/internal/orm/chunk.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1515      +/-   ##
===========================================
- Coverage    51.61%   51.61%   -0.01%     
===========================================
  Files          155      155              
  Lines        12771    12689      -82     
===========================================
- Hits          6592     6549      -43     
+ Misses        5606     5579      -27     
+ Partials       573      561      -12     
Flag Coverage Δ
coordinator 17.22% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao georgehao merged commit bce3383 into develop Aug 30, 2024
5 checks passed
@georgehao georgehao deleted the feat/fix_coordinator_assign_chunk_bug branch August 30, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants