fix(workerpool.go): add nil check in AddTask method to prevent adding…

… nil task to reduce the worker number.
scroll-tech · Dec 18, 2023 · 0dbc007 · 0dbc007
1 parent 99454e5
commit 0dbc007
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/common/utils/workerpool/workerpool.go b/common/utils/workerpool/workerpool.go
@@ -26,12 +26,8 @@ func (vwp *WorkerPool) Run() {
 	for i := 0; i < vwp.maxWorker; i++ {
 		go func() {
 			for task := range vwp.taskQueueChan {
-				if task != nil {
-					task()
-					vwp.wg.Done()
-				} else {
-					return
-				}
+				task()
+				vwp.wg.Done()
 			}
 		}()
 	}
@@ -46,6 +42,9 @@ func (vwp *WorkerPool) Stop() {
 
 // AddTask adds a task to WorkerPool
 func (vwp *WorkerPool) AddTask(task func()) {
+	if task == nil {
+		return
+	}
 	vwp.wg.Add(1)
 	vwp.taskQueueChan <- task
 }