Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.12 #327

Merged
merged 49 commits into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from 48 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
c81fc7f
wip: not compiling
Jul 3, 2024
a74635a
some more updates
roynalnaruto Jul 3, 2024
729f629
config for layer5
noel2004 Jul 5, 2024
317aee5
update e2e test
roynalnaruto Jul 5, 2024
c31898f
add bundle proving
roynalnaruto Jul 5, 2024
f6e200c
remove fields that are not needed anymore
roynalnaruto Jul 5, 2024
a6b95ad
minor change
roynalnaruto Jul 5, 2024
35e30de
correction to the vk name
noel2004 Jul 7, 2024
0fccf52
update dep, dump prove task for batch
noel2004 Jul 8, 2024
fafe569
remove generic from gen_batch_proof
roynalnaruto Jul 8, 2024
058c6dc
verifier has optional deployment code, update
roynalnaruto Jul 8, 2024
f70990d
sigh
roynalnaruto Jul 8, 2024
c2e7bb6
update dep
noel2004 Jul 9, 2024
64d0a77
add test artifacts for bundle test
noel2004 Jul 9, 2024
bd7b2a8
renaming proof generated in e2e
noel2004 Jul 9, 2024
d57ac4b
fix path
noel2004 Jul 9, 2024
9ec69e6
update bundle test
noel2004 Jul 9, 2024
bd9835c
update prover dep
noel2004 Jul 9, 2024
9d745e9
batch header in e2e test (multi-batch)
roynalnaruto Jul 9, 2024
2e60dc3
avoid fetching chunk proof from cache (multi-batch)
roynalnaruto Jul 9, 2024
a10a1cb
update testing data
noel2004 Jul 10, 2024
7055953
fix issue in e2e
noel2004 Jul 10, 2024
f439bd2
delay creation of batch prover
noel2004 Jul 10, 2024
7db9ed1
udpate dep and testing data
noel2004 Jul 10, 2024
deab30d
update dep
noel2004 Jul 10, 2024
1c7307a
update dependency
noel2004 Jul 10, 2024
af1437c
assets for release-v0.12.0-rc.1
lispc Jul 10, 2024
5cad070
batch header refactor (#328)
roynalnaruto Jul 10, 2024
13cea84
add BatchProvingTask for batch tests
lispc Jul 10, 2024
292f5ab
bump prover
roynalnaruto Jul 11, 2024
c95d144
bump prover and fix compilation
roynalnaruto Jul 11, 2024
0fe7a62
assets for release-v0.12.0-rc.2
lispc Jul 12, 2024
b4dfafb
add the preprocessed digest (first 32 bytes of pi)
roynalnaruto Jul 12, 2024
810ed73
redirect proprocessed data to separate hex file in release script
roynalnaruto Jul 12, 2024
527476b
layer6 optimise (advice=1)
lispc Jul 13, 2024
e4dcbca
bump prover
roynalnaruto Jul 13, 2024
50623ee
bump prover
roynalnaruto Jul 16, 2024
7ee1547
fix: compilation
roynalnaruto Jul 16, 2024
c4a2489
correct structure for batch proving task
lispc Jul 16, 2024
5c53d86
add batch-bundle proving e2e test
roynalnaruto Jul 17, 2024
6366e8a
correct data, more logging
roynalnaruto Jul 18, 2024
6c90372
[Refactor] Verifier for compression circuit (#331)
noel2004 Jul 22, 2024
d9a796e
[Feat] A new unittest for evm verifier (#332)
noel2004 Jul 22, 2024
70ec250
assets: v0.12.0-rc.3
lispc Jul 22, 2024
7850e60
bump prover
roynalnaruto Jul 22, 2024
37cca0e
bump prover
roynalnaruto Jul 26, 2024
12bc857
assets: v0.12.0
lispc Aug 2, 2024
5d73889
fix: tmp fix compilation
roynalnaruto Aug 5, 2024
f0ab924
remove old assets
lispc Aug 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 36 additions & 39 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ serde_json = "1.0"
tokio = { version = "1.32", features = ["full"] }

halo2_proofs = { git = "https://github.com/scroll-tech/halo2.git", branch = "v1.1" }
prover = { git = "https://github.com/scroll-tech/zkevm-circuits.git", tag = "v0.11.4", default-features = false, features = ["parallel_syn", "scroll"] }
prover = { git = "https://github.com/scroll-tech/zkevm-circuits.git", branch = "release/v0.12.0", default-features = false, features = ["parallel_syn", "scroll"] }
integration = { path = "integration" }

[patch.crates-io]
Expand Down
6 changes: 6 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,15 @@ test-chunk-prove:
test-batch-prove:
@SCROLL_PROVER_DUMP_YUL=true cargo test --release -p integration --test batch_tests test_batch_prove_verify -- --exact --nocapture

test-bundle-prove:
@SCROLL_PROVER_DUMP_YUL=true cargo test --release -p integration --test bundle_tests test_bundle_prove_verify -- --exact --nocapture

test-e2e-prove:
@SCROLL_PROVER_DUMP_YUL=true cargo test --release -p integration --test e2e_tests test_e2e_prove_verify -- --exact --nocapture

test-batch-bundle-prove:
@SCROLL_PROVER_DUMP_YUL=true cargo test --release -p integration --test e2e_tests test_batch_bundle_verify -- --exact --nocapture

test-ccc:
@cargo test --release -p integration --test unit_tests test_capacity_checker -- --exact --nocapture

Expand Down
10 changes: 9 additions & 1 deletion bin/src/chain_prover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,15 @@ async fn prove_by_batch(
}

#[cfg(feature = "batch-prove")]
prove_utils::prove_batch(&format!("chain_prover: batch-{batch_id}"), chunk_proofs);
use prover::BatchHeader;
#[cfg(feature = "batch-prove")]
let batch_header = BatchHeader::<MAX_AGG_SNARKS>::default();
#[cfg(feature = "batch-prove")]
prove_utils::prove_batch(
&format!("chain_prover: batch-{batch_id}"),
chunk_proofs,
batch_header,
);
}
}
#[tokio::main]
Expand Down
14 changes: 12 additions & 2 deletions bin/src/prove_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,20 @@ use prover::{BlockTrace, ChunkProof};
use std::panic::{catch_unwind, AssertUnwindSafe};

#[cfg(feature = "batch-prove")]
pub fn prove_batch(id: &str, chunk_proofs: Vec<ChunkProof>) {
use prover::{BatchHeader, MAX_AGG_SNARKS};

#[cfg(feature = "batch-prove")]
pub fn prove_batch(
id: &str,
chunk_proofs: Vec<ChunkProof>,
batch_header: BatchHeader<MAX_AGG_SNARKS>,
) {
use prover::BatchProvingTask;

let batch = BatchProvingTask { chunk_proofs };
let batch = BatchProvingTask {
chunk_proofs,
batch_header,
};
let result = catch_unwind(AssertUnwindSafe(|| prover::test::batch_prove(id, batch)));

match result {
Expand Down
14 changes: 14 additions & 0 deletions integration/configs/layer5.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"strategy": "Simple",
"degree": 21,
"num_advice": [
4
],
"num_lookup_advice": [
1
],
"num_fixed": 1,
"lookup_bits": 20,
"limb_bits" :88,
"num_limbs": 3
}
14 changes: 14 additions & 0 deletions integration/configs/layer6.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"strategy": "Simple",
"degree": 26,
"num_advice": [
1
],
"num_lookup_advice": [
1
],
"num_fixed": 1,
"lookup_bits": 25,
"limb_bits": 88,
"num_limbs": 3
}
1 change: 1 addition & 0 deletions integration/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ pub mod capacity_checker;
pub mod evm;
pub mod prove;
pub mod test_util;
mod verifier;
Loading
Loading