[#12] Add links.primo to PrimoRecordGroup

The current link format yields strange results though, see #12 for more info.
scriptotek · Oct 31, 2016 · 62ebd11 · 62ebd11
1 parent b36bb99
commit 62ebd11
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 55 deletions.
diff --git a/app/PrimoRecord.php b/app/PrimoRecord.php
@@ -6,7 +6,7 @@
 use BCLib\PrimoServices\QueryTerm;
 use Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement;
 
-class PrimoRecord implements \JsonSerializable
+class PrimoRecord extends PrimoResult implements \JsonSerializable
 {
     public $orderedMaterialList = ['e-books', 'print-books'];
     protected $brief;
@@ -192,25 +192,16 @@ function extractGetIts($getits)
         return $out;
     }
 
-    public function primoLink()
+    public function link()
     {
-        if ($this->multiple_editions) {
-
-            $queryTerm = new QueryTerm();
-            $queryTerm->set('facet_frbrgroupid', QueryTerm::EXACT, $this->id);
-
-            return 'http://' . $this->deeplinkProvider->view('UBO')
-                ->search($queryTerm, null, 'library_catalogue');
-
-        } else {
-            return 'http://' . $this->deeplinkProvider->view('UBO')
-                ->link($this->id);
-        }
+        return url('primo/records/' .$this->id);
     }
 
-    public function link()
+    public function primoLink()
     {
-        return url('primo/records/' .$this->id);
+        return 'http://' . $this->deeplinkProvider
+            ->view('UBO')
+            ->link($this->id);
     }
 
     public function groupLink()
@@ -223,30 +214,6 @@ public function coverLink()
         return url('primo/records/' .$this->id . '/cover');
     }
 
-    public function jsonSerialize()
-    {
-        return toArray('full');
-    }
-
-    public function toArray($fullRepr=false)
-    {
-        $data = $this->brief;
-        $data['links'] = [
-            'self' => $this->link(),
-        ];
-        if ($fullRepr) {
-            $data['links']['primo'] = $this->primoLink();
-            $data['links']['group'] = $this->groupLink();
-            $data['links']['cover'] = $this->coverLink();
-            // $this->addLocations();
-        }
-
-        if ($fullRepr) {
-            $data = array_merge($data, $this->full);
-        }
-        return $data;
-    }
-
     public function & getComponent(&$components, $id)
     {
         if (count($components) == 1) {
@@ -413,4 +380,4 @@ private function extractArray(QuiteSimpleXMLElement $group, $xpath)
         }, $group->all($xpath));
     }
 
-}
+}
diff --git a/app/PrimoRecordGroup.php b/app/PrimoRecordGroup.php
@@ -6,7 +6,7 @@
 use BCLib\PrimoServices\QueryTerm;
 use Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement;
 
-class PrimoRecordGroup implements \JsonSerializable
+class PrimoRecordGroup extends PrimoResult implements \JsonSerializable
 {
     protected $brief;
     protected $full;
@@ -40,6 +40,16 @@ public function link()
         return url('primo/groups/' .$this->id);
     }
 
+    public function primoLink()
+    {
+        $queryTerm = new QueryTerm();
+        $queryTerm->set('facet_frbrgroupid', QueryTerm::EXACT, $this->id);
+
+        return 'http://' . $this->deeplinkProvider
+            ->view('UBO')
+            ->search($queryTerm, 'bibsys_ils', 'library_catalogue');
+    }
+
     public function process()
     {
         $record = $this->doc->first('./p:PrimoNMBib/p:record');
@@ -54,23 +64,11 @@ public function process()
         return $this;
     }
 
-    public function toArray($expanded=false)
-    {
-        $data = $this->brief;
-        $data['links']['self'] = $this->link();
-        return $data;
-    }
-
-    public function jsonSerialize()
-    {
-        return $this->toArray();
-    }
-
     private function extractArray(QuiteSimpleXMLElement $group, $xpath)
     {
         return array_map(function ($x) {
             return $x->text();
         }, $group->all($xpath));
     }
 
-}
+}
diff --git a/app/PrimoResult.php b/app/PrimoResult.php
@@ -0,0 +1,37 @@
+<?php
+
+namespace App;
+
+use BCLib\PrimoServices\DeepLink;
+use BCLib\PrimoServices\QueryTerm;
+use Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement;
+
+class PrimoResult
+{
+
+    public function toArray($fullRepr=false)
+    {
+        $data = $this->brief;
+        $data['links'] = [
+            'self' => $this->link(),
+        ];
+        if ($fullRepr) {
+            $data['links']['primo'] = $this->primoLink();
+            if ($this instanceof PrimoRecord) {
+	            $data['links']['group'] = $this->groupLink();
+	            $data['links']['cover'] = $this->coverLink();
+            }
+            // $this->addLocations();
+        }
+
+        if ($fullRepr) {
+            $data = array_merge($data, $this->full);
+        }
+        return $data;
+    }
+
+    public function jsonSerialize()
+    {
+        return toArray('full');
+    }
+}