Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update repo structure to more bare bones. #3

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

wkyoshida
Copy link
Member

Looked today some into how to include Scribe-i18n into the other repos..

Actually thinking now of reorganizing the structure of the Scribe-i18n repo a bit, so that including it in the other repos becomes a little cleaner.

In the other repositories, the idea would be roughly to add Scribe-i18n under some i18n/ directory. Issue is that the current structure of the Scribe-i18n repo is roughly:

  • .github/
    • .github files
  • i18n/
    • *.json files
  • ...other files...

All of this would get looped in when inserting Scribe-i18n in the other repos

The idea with this PR is to start restructuring Scribe-i18n to a more bare bones format, i.e. moving the *.json files to the root, removing some files that won't get used (e.g. CHANGELOG.md). Ideally, we could then get a structure where the i18n/ directory in the other repos is minimized to simply:

  • *.json files
  • ...fewer other misc files...

As far as other files, I was thinking of even merging CONTRIBUTING.md and the README.md by simply having the contribution guidelines (e.g. Transifex) directly into the README.md. Removing some of the .github files that won't get used is also another idea.

Let me know if there are questions with what I'm thinking here 😆

Copy link

github-actions bot commented Feb 26, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

@wkyoshida
Copy link
Member Author

Related issue #1

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, @wkyoshida! Let's continue the discussion in #5 for how else we should change things here :)

@andrewtavis andrewtavis merged commit be78600 into scribe-org:main Mar 4, 2024
1 check passed
@wkyoshida wkyoshida deleted the 1 branch March 10, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants