[WIP] Feature/uepr 40 desktop feature parity #461
Conversation
There was a problem hiding this comment.
Wow, there's a lot going on here! There are a couple of things to change, but they're pretty minor... overall this looks good to me. It looks like maybe the development experience is even a little better than before...?
Do you think scratch-webpack-configuration would help here, or would that just complicate things? I'm not suggesting to add it to this PR, just curious about a possible future step.
| "build:dev": "NODE_ENV=production npm run compile && npm run doBuild -- --mode=dev", | ||
| "build:dir": "NODE_ENV=production npm run compile && npm run doBuild -- --mode=dir", | ||
| "build:dist": "NODE_ENV=production npm run compile && npm run doBuild -- --mode=dist", |
There was a problem hiding this comment.
Why is NODE_ENV=production necessary here?
Assuming it is necessary, could you set this up to use crossenv instead? That will allow Windows users to run these commands, too.
| shell: true | ||
| }); | ||
|
|
||
| mainProcess.on('exit', async (code) => { |
There was a problem hiding this comment.
Hmm... can't you do something like await spawn(...)?
(does some web searching)
...nevermind, this looks good. 😅
|
|
||
| const devToolKey = ((process.platform === 'darwin') ? | ||
| { // macOS: command+option+i | ||
| const devToolKey = ((process.platform === 'darwin' || process.platform === 'linux') ? | ||
| { // macOS / linux: command+option+i |
There was a problem hiding this comment.
I think Linux wants the same control+shift+i key combo as Windows here
There was a problem hiding this comment.
I think Linux wants the same
control+shift+ikey combo as Windows here
as a former linux user (and still somewhat uses it), i can confirm
| const baseUrl = (isDevelopment ? | ||
| `http://localhost:${process.env.ELECTRON_WEBPACK_WDS_PORT}/` : | ||
| `file://${__dirname}/` | ||
| const baseUrl = (isDevelopment ? |
There was a problem hiding this comment.
| const baseUrl = (isDevelopment ? | |
| const baseUrl = (isDevelopment ? |
Resolves
Resolves https://scratchfoundation.atlassian.net/browse/UEPR-140
Proposed Changes
Reason for Changes