Add Scroll to Top button to improve page navigation. #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, My remark: It should be good to keep the coherence and have all the components inside its folder. |
|
Sorry for the lack of attention. I just refactored the code. |
scraly
requested changes
Dec 29, 2024
page/src/App.jsx
Outdated
| @@ -9,26 +8,27 @@ import { DatePage } from 'routes/datepage'; | |||
| import { MapPage } from 'routes/mappage'; | |||
| import { ListPage } from 'routes/listpage'; | |||
| import { FilterContext } from 'contexts/FilterContext'; | |||
| import ScrollToTopButton from './components/ScrollToTopButton/ScrollToTopButton'; | |||
There was a problem hiding this comment.
Suggested change
| import ScrollToTopButton from './components/ScrollToTopButton/ScrollToTopButton'; | |
| import { ScrollToTopButton } from './components/ScrollToTopButton/ScrollToTopButton'; |
| import React, { useState, useEffect } from 'react'; | ||
| import 'styles/ScrollToTopButton.css'; | ||
|
|
||
| const ScrollToTopButton = () => { |
There was a problem hiding this comment.
Suggested change
| const ScrollToTopButton = () => { | |
| export const ScrollToTopButton = () => { |
| ); | ||
| }; | ||
|
|
||
| export default ScrollToTopButton; |
There was a problem hiding this comment.
Suggested change
| export default ScrollToTopButton; |
|
Just made the suggested changes. Hope it is all good now. |
scraly
approved these changes
Dec 29, 2024
|
Thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i made a scroll-to-top button to improve navigation. This is my first contribution to a real open source project and hope it is good enough.