This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Add support for WebKit not playing audio unless it is tied to a user interaction #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari won't play audio unless it is initiated as a result of user interaction. I'm working on a web interface for a keyer that I'm building, and the paddle presses get fed to
MorseKeyervia a websocket. Because these events aren't user initiated Safari won't play any audio for them.My solution is to add a new property to
MorsePlayerWAA-openAudioContextthat can be set from client code. If that variable is set it will be used as the audio context for playing tones, and it won't be closed when the tone finishes playing.With this change I can make a button for the user to click to initiate audio from the keyer. In that
onclickevent I can open an audio context and set it on the player.