-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Value.Int should work with int32 #287
base: master
Are you sure you want to change the base?
Conversation
This applies to: * `Value.Int() int32` * `Value.SetInt(int32)` refs #286
This applies to: * `Value.Assign(int32)` * `Value.Assign(uint32)` * `Value.Assign(int64)` * `Value.Assign(uint32)` * `Value.Assign(int)` * `Value.Assign(uint)` refs #286
This applies to: * `Value.Assign(int32)` * `Value.Assign(uint32)` * `Value.Assign(int64)` * `Value.Assign(uint32)` * `Value.Assign(int)` * `Value.Assign(uint)` refs #286
This applies to: * `Value.Assign(int32)` * `Value.Assign(uint32)` * `Value.Assign(int64)` * `Value.Assign(uint32)` * `Value.Assign(int)` * `Value.Assign(uint)` refs #286
That was intense. |
@AshfordN Do you have any idea why it fails in AppVeyor? go-sciter/examples/handlers/handlers.go Lines 28 to 31 in 73bd385
|
Based on my tests, this is caused by trying to build the example(s) in this (value-int32) branch while linking against the current master branch. Now I'm not at all experienced with AppVeyor, but right around line 99 of the output, just before the examples are built, it seems as though the service is pulling in go-sciter from the master branch. |
Apparently, so.
Yeah. I wonder whether we should introduce versioning finally. |
I think it makes sense, especially since this touches, what I consider to be, a core part of the package. This is likely to affect a lot of code bases. |
What is the status of the PR? As far as I see, this is a working branch. The only thing left to do, is to introduce versioning to avoid conflicts with existing code bases. Additionally, since versioning is now required starting with Go 1.16, I think now is a good time to implement it going forward. |
Yep, this. Would you consider filing a PR for versioning? |
No problem. I'll address it as soon as I can. |
This applies to:
Value.Int() int32
Value.SetInt(int32)
fixes #286
cc @AshfordN