ENH - Adds support for L1 + L2 regularization in SparseLogisticRegression #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @AnavAgrawal, I'll merge when it's green Small comment, you sent the PR from your main branch: this means that your main and this repo's main have now diverged, which will be a pain for future PRs. See a summary on good practices and howtos when working with PRs here: https://github.com/mathurinm/github-assignment/?tab=readme-ov-file#summary-how-to-contribute-to-an-existing-repository |
mathurinm
approved these changes
Nov 5, 2024
|
Oh, I see the issue. Thanks for the resource, @mathurinm! I'll keep this in mind for next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context of the PR
Closes #231
Contributions of the PR
Adds ElasticNet like L1 + L2 regularization support for SparseLogisticRegression.
Checks before merging PR