Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parametrized tests #99

Merged

Conversation

ashishpatel16
Copy link
Collaborator

The following test cases were redundant across test_LocalClassifierPerNode, test_LocalClassifierPerParentNode and test_LocalClassifierPerLevel -

  • test_fit_1_class
  • test_empty_levels
  • test_fit_bert
  • test_knn
  • test_fit_multiple_dim_input
  • test_predict_multiple_dim_input

This PR aims at using parametrized tests for executing these tests in a separate file test_LocalClassifiers, where all the common test cases should be written.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@86a1296). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage        ?   98.40%           
=======================================
  Files           ?        8           
  Lines           ?      566           
  Branches        ?        0           
=======================================
  Hits            ?      557           
  Misses          ?        9           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirand863 mirand863 merged commit a4c79e8 into scikit-learn-contrib:main Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants