fix: flow warning fix #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
|
What does hint look like? - |
Signed-off-by: Henry Schreiner <[email protected]>
|
Thanks for the fix! Actually thought we settled on no warn for hint if flow bins don't exist, but seems sth went wrong there. |
jonas-eschle
pushed a commit
that referenced
this pull request
Apr 22, 2024
* fix: flow default and warning fix Signed-off-by: Henry Schreiner <[email protected]> * fix: match description in PR Signed-off-by: Henry Schreiner <[email protected]> * fix: only compute transform if needed Signed-off-by: Henry Schreiner <[email protected]> --------- Signed-off-by: Henry Schreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the full suggested fix to the issues introduced in #413:
flow=.Personally, I'd recommend not supporting
None, and only supporting"none", since it's just a mode like the others and it's not the default if no argument is passed.I think "hint" should also not print a warning.