Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring shortcut.py script #391

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

ye11owSub
Copy link
Contributor

No description provided.

@ye11owSub ye11owSub force-pushed the fixing_imports branch 6 times, most recently from e6b908d to 363317e Compare August 17, 2024 15:30
@ye11owSub
Copy link
Contributor Author

@JarrettSJohnson Could you please take a look at this PR?

@JarrettSJohnson
Copy link
Member

Yup, I plan to review after 3.1 is out later this month.

@ye11owSub
Copy link
Contributor Author

Yup, I plan to review after 3.1 is out later this month.

copy that, thank you

modules/pymol/completing.py Outdated Show resolved Hide resolved
modules/pymol/shortcut.py Outdated Show resolved Hide resolved
modules/pymol/shortcut.py Outdated Show resolved Hide resolved
tests/pymol/test_shortcut.py Outdated Show resolved Hide resolved
@ye11owSub ye11owSub force-pushed the fixing_imports branch 2 times, most recently from f9723da to dfb15b7 Compare January 5, 2025 19:54
Copy link
Member

@JarrettSJohnson JarrettSJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just this final thing and I'll merge it in later this week.

modules/pymol/shortcut.py Outdated Show resolved Hide resolved
@JarrettSJohnson JarrettSJohnson merged commit fef4a02 into schrodinger:master Jan 25, 2025
3 checks passed
@JarrettSJohnson
Copy link
Member

Thanks for your patience. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants