FreeBSD: fixes retrieval of the current working directory for windows/processes without subprocesses #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/processes without subprocesses * Instead of always returning the home directory, which is what cwdOfDeepestChild() would effectively do. * This did not affect Linux and OpenBSD since readPath() would only require the pid. Only FreeBSD stores the cwd in struct proc_s. * getProcesses() also returns the complete proc_s structure now for a given pid, which includes the cwd on FreeBSD. This structure is then used for all subsequent operations. * NOTE: We cannot use the same code paths on BSD and Linux since BSD's procfs does not contain cwd - unless you have mounted linprocfs of course. But it makes sense that xcwd works with the original BSD procfs as well.
|
You should still test this on Linux to make sure I didn't break anything. |
|
@schischi Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cwdOfDeepestChild()would effectively do.readPath()would only require the pid. Only FreeBSD stores the cwd instruct proc_s.getProcesses()also returns the completeproc_sstructure now for a given pid, which includes the cwd on FreeBSD. This structure is then used for all subsequent operations.NOTE to myself: We cannot use the same code paths on BSD and Linux since BSD's procfs does not contain cwd - unless you have mounted linprocfs of course. But it makes sense that xcwd works with the original BSD procfs as well.