Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct issue getHistoricalQuoteData-start-to-give-401-unauthorized-#52 #54

Merged
merged 5 commits into from
Oct 15, 2024
Merged

correct issue getHistoricalQuoteData-start-to-give-401-unauthorized-#52 #54

merged 5 commits into from
Oct 15, 2024

Conversation

jrodriguesd
Copy link
Contributor

Description

@scheb
Copy link
Owner

scheb commented Oct 14, 2024

Would you have a look at the code style issues? Is guess running php-cs-fixer would likely solve half of it.

@jrodriguesd
Copy link
Contributor Author

Dear Sir. I don't know how to solve Codecov Issue. Best regards

@scheb
Copy link
Owner

scheb commented Oct 14, 2024

Looks good! From what I can see, the method private function getHistoricalDataResponseBody seems to be dead code and should be removed. (Or you put your implementation in there and remove the getHistoricalDataResponseBodyJson method. However you like).

The historicalData.csv, dividendData.csv and splitData.csv fixture files should also be removed, since it's no longer needed.

You can't do anything about the Codecov issue, you don't need to worry about that.

@jrodriguesd
Copy link
Contributor Author

Dear Sir. Ready.

Thank you for your guidance. 
Do I need to create another PR?

Best Regards

@scheb scheb merged commit 34ec706 into scheb:4.x Oct 15, 2024
4 of 5 checks passed
@scheb
Copy link
Owner

scheb commented Oct 15, 2024

Thank you for solving this issue! A lot of people are going to love this.

Release as v4.11.0.

krivov pushed a commit to krivov/yahoo-finance-api that referenced this pull request Jan 16, 2025
…cheb#52 (scheb#54)

Fix issue getHistoricalQuoteData start to give 401 unauthorized scheb#52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants