Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loginConfig to source/dest, handle in caller #5

Open
wants to merge 1 commit into
base: scanlonp-add-sources
Choose a base branch
from

Conversation

scanlonp
Copy link
Owner

Features added:

  • Adds LoginConfig interface and LoginType enum.
  • LoginConfig is now a required property in SourceConfig and DestinationConfig.
  • Source/Destination now generate docker login commands.
  • Added logic to determine if the codebuild job needs to logout and login to a different registry.
  • Added documentation detailing that the current Source.ecr and Destination.ecr functions only cover the scope of ECR repositories in the same account as the stack
    • a different function + class will be needed for 'external' ECR repositories

Changes:

  • Setup of Destination. Now bind() returns the destinationConfig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant