feat: add loginConfig to source/dest, handle in caller #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features added:
LoginConfig
interface andLoginType
enum.LoginConfig
is now a required property inSourceConfig
andDestinationConfig
.docker login
commands.logout
andlogin
to a different registry.Source.ecr
andDestination.ecr
functions only cover the scope of ECR repositories in the same account as the stackChanges:
bind()
returns thedestinationConfig
.