5343 Updated wishlist resolver and schema to support pagination #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrsKondratjevs
requested changes
Jan 3, 2023
| protected function getWishlistCollection( | ||
| Wishlist $wishlist, | ||
| array $args | ||
| ): \Magento\Wishlist\Model\ResourceModel\Item\Collection { |
There was a problem hiding this comment.
Import collection in head of file
Comment on lines
+324
to
+326
| $itemsNode = array_filter(iterator_to_array($info->fieldNodes), function ($node) { | ||
| return $node->name->value === 'items_v2'; | ||
| })[0]; |
There was a problem hiding this comment.
Why like that? Do we really need to get the field out here?
Maybe move it into getFieldsFromProductInfo where semantically it can fit?
Comment on lines
+17
to
+18
| <preference for="Magento\WishlistGraphQl\Model\Resolver\WishlistItems" | ||
| type="ScandiPWA\WishlistGraphQl\Model\Resolver\WishlistItemsResolver"/> |
There was a problem hiding this comment.
How looks the original file? Do we really need to override it fully without extending it?
At all, what for this preference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BE modifications for 5343.