Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DateInput): new prop input #4737

Merged
merged 4 commits into from
Feb 11, 2025
Merged

feat(DateInput): new prop input #4737

merged 4 commits into from
Feb 11, 2025

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Feb 5, 2025

Summary

Type

  • Feature

Summarise concisely:

What is expected?

Added a new prop input to show only the calendar par of DateInput
Also fixed a problem in storybook for DateField (value was not updating for non-range values)

@lisalupi lisalupi added the enhancement New feature or request label Feb 5, 2025
@lisalupi lisalupi self-assigned this Feb 5, 2025
@lisalupi lisalupi requested review from johnrazeur, a team and matthprost as code owners February 5, 2025 13:41
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: f827ca8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.01%. Comparing base (7b35655) to head (f827ca8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...omponents/DateInput/components/CalendarContent.tsx 96.77% 1 Missing ⚠️
packages/ui/src/components/DateInput/index.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4737      +/-   ##
==========================================
+ Coverage   88.99%   89.01%   +0.01%     
==========================================
  Files         228      229       +1     
  Lines        7975     7980       +5     
  Branches     3667     3675       +8     
==========================================
+ Hits         7097     7103       +6     
+ Misses        878      877       -1     
Files with missing lines Coverage Δ
packages/form/src/components/DateField/index.tsx 83.33% <100.00%> (+0.40%) ⬆️
packages/ui/src/components/DateInput/Context.tsx 16.66% <ø> (ø)
.../components/DateInput/components/CalendarDaily.tsx 100.00% <100.00%> (ø)
...omponents/DateInput/components/CalendarMonthly.tsx 100.00% <100.00%> (ø)
...s/ui/src/components/DateInput/components/Popup.tsx 95.00% <100.00%> (-1.00%) ⬇️
packages/ui/src/components/DateInput/constants.ts 100.00% <ø> (ø)
packages/ui/src/components/DateInput/helpers.ts 100.00% <100.00%> (+5.12%) ⬆️
...omponents/DateInput/components/CalendarContent.tsx 96.77% <96.77%> (ø)
packages/ui/src/components/DateInput/index.tsx 97.64% <85.71%> (-1.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b35655...f827ca8. Read the comment docs.

@lisalupi lisalupi force-pushed the feat/update-date-input branch from 3f4a4b5 to f827ca8 Compare February 11, 2025 11:04
@lisalupi lisalupi merged commit 3d28302 into main Feb 11, 2025
15 checks passed
@lisalupi lisalupi deleted the feat/update-date-input branch February 11, 2025 14:23
@scaleway-bot scaleway-bot mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants