Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: add support for errcheck #2918

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

lint: add support for errcheck #2918

wants to merge 3 commits into from

Conversation

remyleone
Copy link
Member

No description provided.

@github-actions github-actions bot added rdb Managed MySQL and PostgreSQL issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests instance Instance issues, bugs and feature requests object Object storage issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests container Container issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests iot IoT issues, bugs and feature requests function Serverless function issues, bugs and feature requests iam IAM issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests webhosting Webhosting issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests baremetal vpcgw sdb labels Feb 10, 2025
Codelax
Codelax reviewed Feb 11, 2025
View reviewed changes
internal/meta/meta.go
Comment on lines +166 to 169
var configFileNotFoundError *scw.ConfigFileNotFoundError
if errors.As(err, &configFileNotFoundError) {
config = &scw.Config{}
} else if err != nil {
return nil, nil, err
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This no longer returns an error when not a ConfigFileNotFoundError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codelax Codelax Codelax left review comments

@jremy42 jremy42 Awaiting requested review from jremy42 jremy42 is a code owner

@yfodil yfodil Awaiting requested review from yfodil yfodil is a code owner

@Mia-Cross Mia-Cross Awaiting requested review from Mia-Cross Mia-Cross is a code owner

@Laure-di Laure-di Awaiting requested review from Laure-di Laure-di is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
apple-silicon Apple Silicon issues, bugs and feature requests baremetal container Container issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests function Serverless function issues, bugs and feature requests iam IAM issues, bugs and feature requests instance Instance issues, bugs and feature requests iot IoT issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests object Object storage issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests sdb secret Managed Secret Manager issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw webhosting Webhosting issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remyleone @Codelax