Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(object): getting a 403 when reading bucket should not exit the provider #2302

Merged
merged 3 commits into from
Dec 14, 2023
Merged

fix(object): getting a 403 when reading bucket should not exit the provider #2302

merged 3 commits into from
Dec 14, 2023

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented Dec 12, 2023 •
edited
Loading

Blocks #2280

@Mia-Cross Mia-Cross force-pushed the object_403_as_warnings_when_reading_bucket branch from b419a6e to 4a72765 Compare December 12, 2023 17:00
@Mia-Cross Mia-Cross self-assigned this Dec 12, 2023
@Mia-Cross Mia-Cross added object Object storage issues, bugs and feature requests priority:highest Bugs filled by customers, security issues enhancement labels Dec 12, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (ba35205) 73.73% compared to head (60786ab) 73.68%.

Files Patch % Lines
scaleway/resource_object_bucket.go 22.85% 23 Missing and 4 partials ⚠️
scaleway/helpers_object.go 16.00% 21 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2302      +/-   ##
==========================================
- Coverage   73.73%   73.68%   -0.06%     
==========================================
  Files         218      218              
  Lines       33793    33827      +34     
==========================================
+ Hits        24916    24924       +8     
- Misses       6746     6771      +25     
- Partials     2131     2132       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross marked this pull request as ready for review December 13, 2023 13:08
Codelax
Codelax reviewed Dec 13, 2023
View reviewed changes
scaleway/helpers_object.go Outdated Show resolved Hide resolved
scaleway/resource_object_bucket.go Outdated Show resolved Hide resolved
@remyleone remyleone changed the title feat(object): 403 when reading bucket should not exit the provider fix(object): getting a 403 when reading bucket should not exit the provider Dec 14, 2023
@remyleone remyleone added this pull request to the merge queue Dec 14, 2023
Merged via the queue into scaleway:master with commit bdb2a13 Dec 14, 2023
33 checks passed
@Mia-Cross Mia-Cross deleted the object_403_as_warnings_when_reading_bucket branch December 14, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codelax Codelax Codelax left review comments

@remyleone remyleone remyleone approved these changes

Assignees

@Mia-Cross Mia-Cross

Labels
enhancement object Object storage issues, bugs and feature requests priority:highest Bugs filled by customers, security issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mia-Cross @codecov-commenter @remyleone @Codelax