Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(object): bucket ACL take on bucket's region #2261

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

Mia-Cross
Copy link
Contributor

No description provided.

@Mia-Cross Mia-Cross self-assigned this Nov 30, 2023
@Mia-Cross Mia-Cross added enhancement object Object storage issues, bugs and feature requests labels Nov 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4e4cb0e) 73.73% compared to head (31a6bed) 73.73%.

Files Patch % Lines
scaleway/resource_object_bucket_acl.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2261   +/-   ##
=======================================
  Coverage   73.73%   73.73%           
=======================================
  Files         218      218           
  Lines       33780    33785    +5     
=======================================
+ Hits        24906    24911    +5     
  Misses       6744     6744           
  Partials     2130     2130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross marked this pull request as ready for review December 1, 2023 10:37
scaleway/resource_object_bucket_acl.go Outdated Show resolved Hide resolved
scaleway/resource_object_bucket_acl.go Outdated Show resolved Hide resolved
@Mia-Cross Mia-Cross force-pushed the refacto_object_acl_tests branch from 460137e to 31a6bed Compare December 5, 2023 17:07
@remyleone remyleone added this pull request to the merge queue Dec 6, 2023
Merged via the queue into scaleway:master with commit 1e549a1 Dec 6, 2023
36 checks passed
@Mia-Cross Mia-Cross deleted the refacto_object_acl_tests branch December 6, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement object Object storage issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants