Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tidy): clean up PHP example #71

Merged
merged 3 commits into from
Feb 1, 2024
Merged

chore(tidy): clean up PHP example #71

merged 3 commits into from
Feb 1, 2024

Conversation

Shillaker
Copy link
Contributor

Summary

  • Pin version of aws-sdk-php (current versions break with dependency conflict)
  • Make project ID a variable to avoid having it in a tfvars file
  • Avoid copy-pasting in example using Terraform outputs

Checklist

  • I have reviewed this myself.
  • I have attached a README to my example. You can use this template as reference.
  • I have updated the project README to link my example.

Details

More recent versions of the aws-sdk-php dependency break with an error of the form:

DEBUG - Fatal error: Declaration of RingCentral\Psr7\Response::getStatusCode() must be compatible with Psr\Http\Message\ResponseInterface::getStatusCode(): int in /home/app/vendor/ringcentral/psr7/src/Response.php on line 109 source=user stream=stdout

@Shillaker Shillaker self-assigned this Jan 30, 2024
@Shillaker Shillaker merged commit 400fa5f into main Feb 1, 2024
8 checks passed
@Shillaker Shillaker deleted the php-s3-example-update branch February 1, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants