Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(examples): add NATS triggers in triggers-getting-started #66

Merged
merged 3 commits into from
Jan 11, 2024
Merged

docs(examples): add NATS triggers in triggers-getting-started #66

merged 3 commits into from
Jan 11, 2024

Conversation

Bemilie
Copy link
Contributor

@Bemilie Bemilie commented Jan 8, 2024 •
edited
Loading

Summary

Update triggers-getting-started example to include NATS triggers.

Checklist

  • I have reviewed this myself.
  • I have attached a README to my example. You can use this template as reference.
  • I have updated the project README to link my example.

Details

Tested with:

terraform apply
python3 tests/send_nats_messages.py

Function logs were similar to what's described in the README.

Also tested with SQS triggers to ensure that no regression was made.

@Bemilie Bemilie marked this pull request as ready for review January 9, 2024 09:21
@Bemilie Bemilie requested a review from Shillaker January 9, 2024 09:21
@Bemilie Bemilie merged commit e8db0a0 into main Jan 11, 2024
8 checks passed
@Bemilie Bemilie deleted the docs-add-nats-in-triggers-getting-started branch January 11, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shillaker Shillaker Shillaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bemilie @Shillaker