Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): unknown property accessKey in createClient #1781

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dehy
Copy link

@dehy dehy commented Feb 6, 2025

The createClient() method is using Partial<Settings> type, extending DefaultValues that was using ProfileDefaultValues type. This last type lacked the accessKey and secretKey properties.

DefaultValues type is now inheriting Profile type, which contains the correct properties.

fixes #1752

@dehy dehy requested a review from remyleone as a code owner February 6, 2025 11:09
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: fbc09d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dehy dehy changed the title fix unknown property accessKey in createClient fix(types): unknown property accessKey in createClient Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid createClient signature type
2 participants