Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(block): add snapshot wait command #4455

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jan 21, 2025

Adding more waiters to use in #4435

@Codelax Codelax added enhancement sbs Scaleway Block Storage issues, bugs and feature requests labels Jan 21, 2025
@Codelax Codelax requested a review from remyleone as a code owner January 21, 2025 16:30
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.81%. Comparing base (5bf53e0) to head (4ffdea5).
Report is 452 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4455      +/-   ##
==========================================
- Coverage   75.45%   70.81%   -4.65%     
==========================================
  Files         202      299      +97     
  Lines       44323    66136   +21813     
==========================================
+ Hits        33444    46832   +13388     
- Misses       9653    17660    +8007     
- Partials     1226     1644     +418     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It represents a list of all statuses that can be used as terminal statuses if choosed by the user
…st of all statuses that can be used as terminal statuses if choosed by the user

typo
…ts a list of all statuses that can be used as terminal statuses if choosed by the user

remove extra character
@remyleone remyleone added this pull request to the merge queue Jan 23, 2025
Merged via the queue into scaleway:master with commit 080a371 Jan 23, 2025
13 checks passed
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement sbs Scaleway Block Storage issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants