Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: convert workspace folder to be a Metals project on chosen commands #7135

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

kasiaMarek
Copy link
Contributor

(e.g. import build) also assume, that workspace folder is Metals project if it contains .bloop folder

resolves: #7031

…n commands (e.g. import build)

also assume, that workspace folder is Metals project if it contains `.bloop` folder
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise LGTM

@@ -393,7 +393,9 @@ object MetalsEnrichments
def isScalaProject(): Boolean =
containsProjectFilesSatisfying(_.isScala)
def isMetalsProject(): Boolean =
containsProjectFilesSatisfying(_.isScalaOrJavaFilename)
path.resolve(".metals").exists ||
path.resolve(".bloop").exists ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also include .bsp ?

Copy link
Contributor Author

@kasiaMarek kasiaMarek Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a Scala thing, so I added it too.

@kasiaMarek kasiaMarek merged commit edd5d12 into scalameta:main Jan 31, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No workspace chosen to import" error on gradle project
2 participants