[2.x] upgrade and reenable sbt'contraband plugin #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtjeferreira
force-pushed
the
contraband
branch
from
38f5c2a to
6862d88
Compare
jtjeferreira
force-pushed
the
contraband
branch
from
6862d88 to
8a21e0d
Compare
eed3si9n
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed sbt-contraband was disabled, but I though it was disabled because there was no version with support for sbt 2.x.
I upgraded to 0.6.0 and reenabled the plugin.
But then it occurred to me, that the sbt version in this project is still 1.9.3 (which is okay), and the reason for disabling it instead was commit b807671.
So unsure about the reason why this was disabled before, this PR enables it again