Add markout shard to benchmark
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`markout` returns HTML with only single quotes for some reason. To make the equality checks work in the benchmark, we need to swap them to double quotes.
The list now includes the `markout` shard. The numbers have changed since I ran them on a new machine.
|
No problem @sbsoftware, nice to know that blueprint isn't so unoptimized as I thought. Btw, nice job with to_html.cr, I learn a lot of Crystal reading your code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch benchmark can be found in the changes.
What stands out is the drastically increased performance of
blueprintonce I didn't reuse the same object for rendering all over again but instantiated a new one each run. This didn't have any effect on all the other shards tested here. I can't explain why this is, but I'll leave it that way now. (cc @stephannv sorry I made your shard look worse than it actually is until now, that wasn't on purpose)