Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make configuration texts localizable #332

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

yeshjho
Copy link

@yeshjho yeshjho commented Dec 23, 2024

The DisplayName and Tootltip of ModConfiguration and ConfigProperty were FString, which isn't localizable, so changed them to be FText.

Tested with an existing mod, the values of the fields were preserved, this change is backwards compatible.

End Result (Localization: Korean):
image

@yeshjho yeshjho changed the base branch from master to dev December 23, 2024 23:27
Copy link
Member

@budak7273 budak7273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working on ExampleMod. I'm quite surprised it's backwards compatible with no other changes. I guess UE has something built in to handle FString -> FText?

budak7273 added a commit that referenced this pull request Jan 24, 2025
#332 revealed that UE will preserve data in BP assets when making this switch
BP commands auto-update but C++ needs switching to LOCTEXT/NSLOCTEXT
@yeshjho
Copy link
Author

yeshjho commented Jan 24, 2025

(Cross-post from Discord)
FTextProperty::ConvertFromType handles that.

@budak7273 budak7273 merged commit 495c67a into satisfactorymodding:dev Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants