Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Dart Sass version for the sass-parser dependency #2490

Merged
merged 2 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,12 @@ jobs:
check-latest: true
registry-url: 'https://registry.npmjs.org'

- name: Get version
id: version
run: |
echo "version=$(jq .version pkg/sass-parser/package.json)" | tee --append "$GITHUB_OUTPUT"

# The repo package has a file dependency, but the released version needs
# a real dependency on the released version of Sass.
- run: npm install sass@${{ steps.version.outputs.version }}
- name: Get Dart Sass version
id: dart-sass-version
run: echo "version=${GITHUB_REF##*/}" | tee --append "$GITHUB_OUTPUT"
- run: npm install sass@${{ steps.dart-sassversion.outputs.version }}
working-directory: pkg/sass-parser/

- run: npm run compile
Expand All @@ -143,7 +141,11 @@ jobs:
NODE_AUTH_TOKEN: '${{ secrets.NPM_TOKEN }}'
working-directory: pkg/sass-parser/

- run: git tag sass-parser/${{ steps.version.outputs.version }}
- name: Get Sass parser version
id: sass-parser-version
run: |
echo "version=$(jq .version pkg/sass-parser/package.json)" | tee --append "$GITHUB_OUTPUT"
- run: git tag sass-parser/${{ steps.sass-parser-version.outputs.version }}
- run: git push --tag

deploy_homebrew:
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.83.3

* No user-visible changes.

## 1.83.2

* Properly display deprecation IDs for the JS Sass API.
Expand Down
4 changes: 4 additions & 0 deletions pkg/sass-parser/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.4.11

* Fix the automated release process.

## 0.4.10

* No user-visible changes.
Expand Down
4 changes: 2 additions & 2 deletions pkg/sass-parser/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sass-parser",
"version": "0.4.10",
"version": "0.4.11",
"description": "A PostCSS-compatible wrapper of the official Sass parser",
"repository": "sass/sass",
"author": "Google Inc.",
Expand Down Expand Up @@ -32,7 +32,7 @@
},
"dependencies": {
"postcss": ">=8.4.41 <8.5.0",
"sass": "^1.83.1"
"sass": "file:../../build/npm"
},
"devDependencies": {
"@types/jest": "^29.5.12",
Expand Down
4 changes: 4 additions & 0 deletions pkg/sass_api/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 15.0.3

* No user-visible changes.

## 15.0.2

* No user-visible changes.
Expand Down
4 changes: 2 additions & 2 deletions pkg/sass_api/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ name: sass_api
# Note: Every time we add a new Sass AST node, we need to bump the *major*
# version because it's a breaking change for anyone who's implementing the
# visitor interface(s).
version: 15.0.2
version: 15.0.3
description: Additional APIs for Dart Sass.
homepage: https://github.com/sass/dart-sass

environment:
sdk: ">=3.3.0 <4.0.0"

dependencies:
sass: 1.83.2
sass: 1.83.3

dev_dependencies:
dartdoc: ^8.0.14
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sass
version: 1.83.2
version: 1.83.3
description: A Sass implementation in Dart.
homepage: https://github.com/sass/dart-sass

Expand Down
Loading