-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unit test doc #2221
base: main
Are you sure you want to change the base?
Update unit test doc #2221
Conversation
📝 WalkthroughWalkthroughThe documentation for BPMN Unit Tests has been comprehensively updated to provide a more detailed and structured guide for testing BPMN process models. The new content focuses on explaining the purpose and methods of creating unit tests, introducing two distinct approaches: using a test JSON file and utilizing the properties panel. The documentation now includes a more in-depth explanation of testing benefits, step-by-step implementation guidance, and a comparative overview of the testing methods. Changes
Sequence DiagramsequenceDiagram
participant User
participant BPMN Model
participant Test Framework
User->>BPMN Model: Prepare Unit Test
alt JSON File Method
User->>Test Framework: Create test JSON
Test Framework->>BPMN Model: Apply test configuration
else Properties Panel Method
User->>BPMN Model: Configure tests directly
BPMN Model->>Test Framework: Generate test cases
end
Test Framework->>BPMN Model: Execute Unit Tests
Test Framework-->>User: Provide Test Results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
docs/how_to_guides/building_diagrams/bpmn_unit_tests.md (4)
9-9
: Fix grammar in the introductory sentence.Add the article "an" before "in-depth".
-Lets take a look at in-depth discussion on the two ways of creating BPMN Unit Tests: through a test JSON file and via the properties panel. +Let's take a look at an in-depth discussion on the two ways of creating BPMN Unit Tests: through a test JSON file and via the properties panel.🧰 Tools
🪛 LanguageTool
[uncategorized] ~9-~9: You might be missing the article “an” here.
Context: ...break the process. Lets take a look at in-depth discussion on the two ways of cre...(AI_EN_LECTOR_MISSING_DETERMINER_AN)
52-58
: Fix markdown list indentation.The unordered list items should have consistent indentation with the parent content.
-**`test_case_1`**: - - Mocks a Service Task (`service_task_one`) output as `"mocked_service_result"`. - - Verifies that the process completes with the expected output: `"mocked_service_result"`. +**`test_case_1`**: +- Mocks a Service Task (`service_task_one`) output as `"mocked_service_result"`. +- Verifies that the process completes with the expected output: `"mocked_service_result"`. -**`test_case_2`**: - - Simulates a User Task (`user_task_1`) where the user enters `"user_input"`. - - Ensures the process captures this input correctly in the output. +**`test_case_2`**: +- Simulates a User Task (`user_task_1`) where the user enters `"user_input"`. +- Ensures the process captures this input correctly in the output.🧰 Tools
🪛 LanguageTool
[uncategorized] ~52-~52: Loose punctuation mark.
Context: ... } } } ```test_case_1
: - Mocks a Service Task (`service_task...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...ked_service_result". **
test_case_2**: - Simulates a User Task (
user_task_1...(UNLIKELY_OPENING_PUNCTUATION)
🪛 Markdownlint (0.37.0)
53-53: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
54-54: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
57-57: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
58-58: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
82-87
: Fix markdown list indentation in example section.The unordered list items should have consistent indentation with the parent content.
-**Task Details**: - - **Script Code:** `a = 1`. +**Task Details**: +- **Script Code:** `a = 1`. -**Unit Test Configuration**: - - **Input JSON:** `{ "a": 2 }` - - **Expected Output JSON:** `{ "a": 2 }` +**Unit Test Configuration**: +- **Input JSON:** `{ "a": 2 }` +- **Expected Output JSON:** `{ "a": 2 }`🧰 Tools
🪛 Markdownlint (0.37.0)
83-83: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
86-86: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
87-87: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
100-100
: Improve politeness in the conclusion.Add "please" to make the request more polite.
-This documentation comprehensively explains both methods, their use cases, and how to implement them with practical examples. Let me know if further refinements are needed! +This documentation comprehensively explains both methods, their use cases, and how to implement them with practical examples. Please let me know if further refinements are needed!🧰 Tools
🪛 LanguageTool
[style] ~100-~100: This expression usually appears with a “please” in front of it.
Context: ...implement them with practical examples. Let me know if further refinements are needed!(INSERT_PLEASE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/images/unit_test_properties_panel.png
is excluded by!**/*.png
📒 Files selected for processing (1)
docs/how_to_guides/building_diagrams/bpmn_unit_tests.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/how_to_guides/building_diagrams/bpmn_unit_tests.md
[uncategorized] ~9-~9: You might be missing the article “an” here.
Context: ...break the process. Lets take a look at in-depth discussion on the two ways of cre...
(AI_EN_LECTOR_MISSING_DETERMINER_AN)
[uncategorized] ~52-~52: Loose punctuation mark.
Context: ... } } } ``` test_case_1
: - Mocks a Service Task (`service_task...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...ked_service_result". **
test_case_2**: - Simulates a User Task (
user_task_1...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~100-~100: This expression usually appears with a “please” in front of it.
Context: ...implement them with practical examples. Let me know if further refinements are needed!
(INSERT_PLEASE)
🪛 Markdownlint (0.37.0)
docs/how_to_guides/building_diagrams/bpmn_unit_tests.md
53-53: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
54-54: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
57-57: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
58-58: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
83-83: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
86-86: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
87-87: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: typeguard 3.12 / ubuntu-latest sqlite
- GitHub Check: typeguard 3.11 / ubuntu-latest sqlite
- GitHub Check: tests 3.11 / macos-latest sqlite
- GitHub Check: tests 3.10 / ubuntu-latest sqlite
- GitHub Check: tests 3.12 / ubuntu-latest sqlite
- GitHub Check: tests 3.11 / ubuntu-latest sqlite
- GitHub Check: tests 3.12 / ubuntu-latest postgres
- GitHub Check: tests 3.11 / ubuntu-latest postgres
- GitHub Check: tests 3.12 / ubuntu-latest mysql
- GitHub Check: tests 3.11 / ubuntu-latest mysql
- GitHub Check: check_docker_start_script
- GitHub Check: build
- GitHub Check: pixeebot[bot]
🔇 Additional comments (1)
docs/how_to_guides/building_diagrams/bpmn_unit_tests.md (1)
1-100
: Great job on the documentation update!The documentation is well-structured and provides comprehensive guidance on BPMN Unit Testing. The addition of the properties panel section and the comparison table makes it easier for users to understand and choose between the two testing methods. The examples are clear and practical.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~9-~9: You might be missing the article “an” here.
Context: ...break the process. Lets take a look at in-depth discussion on the two ways of cre...(AI_EN_LECTOR_MISSING_DETERMINER_AN)
[uncategorized] ~52-~52: Loose punctuation mark.
Context: ... } } } ```test_case_1
: - Mocks a Service Task (`service_task...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...ked_service_result". **
test_case_2**: - Simulates a User Task (
user_task_1...(UNLIKELY_OPENING_PUNCTUATION)
[style] ~100-~100: This expression usually appears with a “please” in front of it.
Context: ...implement them with practical examples. Let me know if further refinements are needed!(INSERT_PLEASE)
🪛 Markdownlint (0.37.0)
53-53: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
54-54: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
57-57: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
58-58: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
83-83: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
86-86: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
87-87: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
Added new section on properties panel and refined unit test documentation
Summary by CodeRabbit