Allow optional item_class in ListComponent
#74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to not specify `item_class` in `ListComponent`. Instead, it will be automatically filled with value passed in `Generic[ListItemType]`. `Warning`: The `item_class` specification is still available, but it is deprecated and will be removed soon.
M1troll
requested review from
ron8mcr,
TheSuperiorStanislav and
NikAzanov
as code owners
TheSuperiorStanislav
approved these changes
Jul 5, 2024
Comment on lines
+195
to
+209
| if item_class := getattr(self, "item_class", None): | ||
| import warnings | ||
|
|
||
| warnings.warn( | ||
| DeprecationWarning( | ||
| "\nSpecifying `item_class` attribute in `ListComponent` " | ||
| f"({self.__class__}) is DEPRECATED. It is now " | ||
| "automatically substituted from Generic[ListItemType]. " | ||
| "Ability to specify this attribute will be removed soon.", | ||
| ), | ||
| stacklevel=2, | ||
| ) | ||
| self._item_class = item_class | ||
| else: | ||
| self._item_class = self._get_list_item_class() |
There was a problem hiding this comment.
I think since pomcorn is pre-release, maybe it's okay to just drop it
There was a problem hiding this comment.
Then we would have to update all of our current projects... It's not difficult, but it will takes time
ron8mcr
approved these changes
Jul 5, 2024
M1troll
deleted the
feature/add-ability-to-not-specify-item-class-in-list-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to not specify
item_classinListComponent. Instead, it will be automatically filled with value passed inGeneric[ListItemType].Warning: The
item_classspecification is still available, but it is deprecated and will be removed soon.