Remove simple Component
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M1troll
requested review from
ron8mcr,
TheSuperiorStanislav and
NikAzanov
as code owners
TheSuperiorStanislav
approved these changes
May 15, 2024
ron8mcr
approved these changes
May 16, 2024
NikAzanov
approved these changes
May 16, 2024
We decided to keep only one view of the component (with the base locator), because practice has shown that component always has a locator that can be called base locator, and waiting for default display makes tests more stable. We rename `ComponentWithBaseLocator` to `Component` and remove simple `Component` class.
M1troll
force-pushed
the
feature/delete-simple-component
branch
from
b8fe554 to
3e6fc36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to keep only one view of the component (with the base locator), because practice has shown that component always has a locator that can be called base locator, and waiting for default display makes tests more stable.
We rename
ComponentWithBaseLocatortoComponentand remove simpleComponentclass.The diagrams have also been reworked for rendering with mermaid