Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace is_loaded property to check_page_is_loaded method #14

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

M1troll
Copy link
Contributor

@M1troll M1troll commented Dec 1, 2023

There were cases when a developer forgot to specify @property above is_loaded method and because of this wait_until_loaded worked incorrectly (always returned True). To minimize such mistakes, it was decided to explicitly call this check as a method.

@M1troll M1troll self-assigned this Dec 1, 2023
`is_loaded` property was replaced by
`check_page_is_loaded` method, because there
were cases when a developer forgot to set
`@property`, and because of that
`wait_until_loaded` did not work correctly. It
was decided to explicitly call this check as a
method to minimize such mistakes.
@M1troll M1troll force-pushed the feature/refactor-is-loaded-property branch from 8645aff to 3f2b0f6 Compare December 1, 2023 02:04
@M1troll M1troll marked this pull request as ready for review December 1, 2023 02:18
demo/pages/base/base_page.py Show resolved Hide resolved
docs/CHANGELOG.rst Outdated Show resolved Hide resolved
@M1troll M1troll force-pushed the feature/refactor-is-loaded-property branch from 04a08ff to f3acf74 Compare December 1, 2023 03:48
docs/CHANGELOG.rst Outdated Show resolved Hide resolved
@M1troll M1troll force-pushed the feature/refactor-is-loaded-property branch from 2dafd9d to fd5edc0 Compare December 1, 2023 07:27
@M1troll M1troll merged commit 406cf14 into main Dec 1, 2023
@M1troll M1troll deleted the feature/refactor-is-loaded-property branch December 1, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants