Improve item class getting #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the previous pomcorn 0.8.1 update, we encountered two issues: * TypeAlias passed in first generic parametter don't pass `is_valid_item_class` check * We could not use `ListComponent` as a parameterized type (e.g., `list_component = List[ItemClass, Page]`). In this commit, we improved getting `_item_class` for a parameterized `ListComponent` and added support for TypeAlias in `is_valid_item_class`. We also added tests for these cases.
M1troll
requested review from
ron8mcr,
TheSuperiorStanislav and
NikAzanov
as code owners
TheSuperiorStanislav
approved these changes
Dec 4, 2024
NikAzanov
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the previous pomcorn 0.8.1 update, we encountered two issues:
is_valid_item_classcheckListComponentas a parameterized typeExample:
In this commit, we improved getting
_item_classfor a parameterizedListComponentand added support for TypeAlias in
is_valid_item_class+ added tests for these cases.