handle PIN with special characters in scripts piping to fido2luks-0.2.19

saravanan30erd · Nov 11, 2024 · 44c3fae · 44c3fae
1 parent 71c244d
commit 44c3fae
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/skfde-cred b/src/skfde-cred
@@ -7,7 +7,7 @@ echo "Generate the SoloKey credential"
 read -s -p "Enter the SoloKey PIN and Press the button: " PIN
 echo -e "\nRemember to press the SoloKey button if necessary"
 
-CREDENTIAL="$(printf $PIN | fido2luks credential \
+CREDENTIAL="$(echo -n ${PIN} | fido2luks credential \
   --pin --pin-source /dev/stdin 2>&1)"
 
 echo "SoloKey credential : $CREDENTIAL"
diff --git a/src/skfde-enroll b/src/skfde-enroll
@@ -90,7 +90,7 @@ fi
 if [ -z "$SKFDE_RESPONSE" ]; then
   read -s -p "Enter the SoloKey PIN: " PIN
   echo -e "\nRemember to press the SoloKey button if necessary"
-  SKFDE_RESPONSE="$(printf $PIN | fido2luks print-secret $SKFDE_CREDENTIAL \
+  SKFDE_RESPONSE="$(echo -n ${PIN} | fido2luks print-secret $SKFDE_CREDENTIAL \
     --salt string:$SKFDE_CHALLENGE --pin --pin-source /dev/stdin 2>&1)"
   SKFDE_PASSPHRASE="$SKFDE_RESPONSE"
 fi

diff --git a/src/skfde-format b/src/skfde-format
@@ -27,7 +27,7 @@ fi
 if [ -z "$SKFDE_RESPONSE" ]; then
   read -s -p "Enter the SoloKey PIN: " PIN
   echo -e "\nRemember to press the SoloKey button if necessary"
-  SKFDE_RESPONSE="$(printf $PIN | fido2luks print-secret $SKFDE_CREDENTIAL \
+  SKFDE_RESPONSE="$(echo -n ${PIN} | fido2luks print-secret $SKFDE_CREDENTIAL \
     --salt string:$SKFDE_CHALLENGE --pin --pin-source /dev/stdin 2>&1)"
   SKFDE_PASSPHRASE="$SKFDE_RESPONSE"
 fi

diff --git a/src/skfde-open b/src/skfde-open
@@ -109,7 +109,7 @@ fi
 if [ -z "$SKFDE_RESPONSE" ]; then
   read -s -p "Enter the SoloKey PIN: " PIN
   echo -e "\nRemember to press the SoloKey button if necessary"
-  SKFDE_RESPONSE="$(printf $PIN | fido2luks print-secret $SKFDE_CREDENTIAL \
+  SKFDE_RESPONSE="$(echo -n ${PIN} | fido2luks print-secret $SKFDE_CREDENTIAL \
     --salt string:$SKFDE_CHALLENGE --pin --pin-source /dev/stdin 2>&1)"
   SKFDE_PASSPHRASE="$SKFDE_RESPONSE"
 fi