Doc/casey j may/text fields #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18chowdhary
requested changes
Apr 19, 2022
There was a problem hiding this comment.
Other changes to make but Github wouldn't let me leave comments on the files:
- Add a header comment to the top of the LargeTextFiedl file describing what the component is - refer to the other components for examples. In the header comment, make sure to explain what each of the props to this component are. Can be very brief in a bullet list.
- Make sure all single line comments are preceded with // instead of /*.
- Follow a similar process for OpenTextField and OpenTextFieldWithSelection.
| @@ -53,7 +53,7 @@ const LargeTextField = (props) => { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| /* Calls when text is updated, evaluates the validity of text based on TextFieldValidation component */ | |||
| const onTextChange = (text) => { | |||
There was a problem hiding this comment.
I would definitely add more comments to the body of this function explaining how the validation works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still have some question parts and parts that aren't commented because I'm not quite sure how they work, but wanted to put a pull request to contain feedback and monitor progress.