Doc/casey j may/text field validation #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18chowdhary
requested changes
Apr 19, 2022
src/utils/TextFieldValidation.js
Outdated
| @@ -4,6 +4,8 @@ export class TextFieldValidation { | |||
| this.status = null; | |||
| this.validationData = null; | |||
| } | |||
|
|
|||
| /* prevents input lag by delaying the run until typing ends */ | |||
There was a problem hiding this comment.
minor style note - these can be // comments and not // comments because they're single-line comments. If they were multi-line comments, then I would expect / */ around the comments.
src/utils/TextFieldValidation.js
Outdated
| @@ -12,9 +14,8 @@ export class TextFieldValidation { | |||
| }; | |||
| } | |||
|
|
|||
|
|
|||
| /* checks to see whether the input fits in the customized paramaters */ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny pull request! Probably needed to combine this with some other commenting.