fix(prosemirror-resizable-view): set initial size CSS styles (remirro…

…r#1347)
sandzone · Oct 24, 2021 · a469345 · a469345
1 parent 2cfbca2
commit a469345
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/.changeset/green-glasses-poke.md b/.changeset/green-glasses-poke.md
@@ -0,0 +1,5 @@
+---
+'prosemirror-resizable-view': patch
+---
+
+Fix a bug that causes initial size CSS in resizable view not be set.
diff --git a/packages/prosemirror-resizable-view/src/prosemirror-resizable-view.ts b/packages/prosemirror-resizable-view/src/prosemirror-resizable-view.ts
@@ -126,13 +126,13 @@ export abstract class ResizableNodeView implements NodeView {
 
     if (initialSize) {
       setStyle(outer, {
-        width: `${initialSize.width}px`,
-        height: `${initialSize.height}px`,
+        width: normalizeSize(initialSize.width),
+        height: normalizeSize(initialSize.height),
       });
     } else {
       setStyle(outer, {
-        width: node.attrs.width,
-        height: node.attrs.height,
+        width: normalizeSize(node.attrs.width),
+        height: normalizeSize(node.attrs.height),
       });
     }
 
@@ -326,3 +326,13 @@ function sameMarkup(node1: ProsemirrorNode, node2: ProsemirrorNode, ignoreAttrs:
 
   return same;
 }
+
+function normalizeSize(size: string | number | null | undefined): string | undefined {
+  if (typeof size === 'number') {
+    return `${size}px`;
+  } else if (size) {
+    return size;
+  } else {
+    return undefined;
+  }
+}
diff --git a/support/root/.eslintrc.js b/support/root/.eslintrc.js
@@ -275,7 +275,6 @@ let config = {
     // Built in eslint rules
     'no-constant-condition': 'off', // To many false positives
     'no-empty': 'warn',
-    'no-else-return': 'warn',
     'no-useless-escape': 'warn',
     'default-case': 'off',
     'default-case-last': 'error',