Nick/link check #359
Merged
Nick/link check #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The link checker didn't flake on multiple runs. Unfortunately, I wasn't able to figure out how to make the output more verbose, so it's possible I misconfigured it and we are no longer checking links (I don't think that's likely but I can't say 100%) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #358 (if successful)
Also adds codespell to our checks.
Its used in another repo I was contributing to, has 2k stars, runs fast, and is easy to configure. I didn't dig much deeper than that and it caught a bunch of our typos.
I updated the contributing doc, our pre-commit, package tests, and pyproject config to support it. I think that covers all the bases.
📚 Documentation preview 📚: https://pyttb--359.org.readthedocs.build/en/359/